From: tip-bot for Kirill Tkhai <tkhai@yandex.ru>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
peterz@infradead.org, linux-rt-users@vger.kernel.org,
rostedt@goodmis.org, tkhai@yandex.ru, tglx@linutronix.de
Subject: [tip:sched/core] sched/rt: Do not account zero delta_exec in update_curr_rt()
Date: Thu, 31 Jan 2013 03:06:09 -0800 [thread overview]
Message-ID: <tip-fc79e240be5aa379dd36a62158be5a5ee0e4aec7@git.kernel.org> (raw)
In-Reply-To: <931541359550236@web1g.yandex.ru>
Commit-ID: fc79e240be5aa379dd36a62158be5a5ee0e4aec7
Gitweb: http://git.kernel.org/tip/fc79e240be5aa379dd36a62158be5a5ee0e4aec7
Author: Kirill Tkhai <tkhai@yandex.ru>
AuthorDate: Wed, 30 Jan 2013 16:50:36 +0400
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 31 Jan 2013 10:31:13 +0100
sched/rt: Do not account zero delta_exec in update_curr_rt()
There are several places of consecutive calls of
dequeue_task_rt() and put_prev_task_rt() in the scheduler.
For example, function rt_mutex_setprio() does it.
The both calls lead to update_curr_rt(), the second of it
receives zeroed delta_exec. The only effective action in this
case is call of sched_rt_avg_update(), which can change
rq->age_stamp and rq->rt_avg. But it is possible in case of
""floating"" rq->clock. This fact is not reasonable to be
accounted. Another actions do nothing.
Signed-off-by: Kirill V Tkhai <tkhai@yandex.ru>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>
CC: linux-rt-users <linux-rt-users@vger.kernel.org>
Link: http://lkml.kernel.org/r/931541359550236@web1g.yandex.ru
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/sched/rt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index 2f69ca9..94abca4 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -925,8 +925,8 @@ static void update_curr_rt(struct rq *rq)
return;
delta_exec = rq->clock_task - curr->se.exec_start;
- if (unlikely((s64)delta_exec < 0))
- delta_exec = 0;
+ if (unlikely((s64)delta_exec <= 0))
+ return;
schedstat_set(curr->se.statistics.exec_max,
max(curr->se.statistics.exec_max, delta_exec));
prev parent reply other threads:[~2013-01-31 11:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 12:50 [PATCH]sched/rt: Do not account zero delta_exec in update_curr_rt() Kirill Tkhai
2013-01-30 13:35 ` Steven Rostedt
2013-01-31 11:06 ` tip-bot for Kirill Tkhai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-fc79e240be5aa379dd36a62158be5a5ee0e4aec7@git.kernel.org \
--to=tkhai@yandex.ru \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).