From: Joshua Kinard <kumba@gentoo.org>
To: Thomas Bogendoerfer <tbogendoerfer@suse.de>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] rts: ds1685: remove not needed fields from private struct
Date: Sat, 12 Oct 2019 18:41:56 -0400 [thread overview]
Message-ID: <00fbd208-128d-f86d-d9db-6caa1ecc381d@gentoo.org> (raw)
In-Reply-To: <20191011150546.9186-1-tbogendoerfer@suse.de>
On 10/11/2019 11:05, Thomas Bogendoerfer wrote:
> A few of the fields in struct ds1685_priv aren't needed at all,
> so we can remove it.
>
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> ---
> drivers/rtc/rtc-ds1685.c | 3 ---
> include/linux/rtc/ds1685.h | 3 ---
> 2 files changed, 6 deletions(-)
>
> diff --git a/drivers/rtc/rtc-ds1685.c b/drivers/rtc/rtc-ds1685.c
> index 184e4a3e2bef..51f568473de8 100644
> --- a/drivers/rtc/rtc-ds1685.c
> +++ b/drivers/rtc/rtc-ds1685.c
> @@ -1086,12 +1086,10 @@ ds1685_rtc_probe(struct platform_device *pdev)
> * Set the base address for the rtc, and ioremap its
> * registers.
> */
> - rtc->baseaddr = res->start;
> rtc->regs = devm_ioremap(&pdev->dev, res->start, rtc->size);
> if (!rtc->regs)
> return -ENOMEM;
> }
> - rtc->alloc_io_resources = pdata->alloc_io_resources;
>
> /* Get the register step size. */
> if (pdata->regstep > 0)
> @@ -1271,7 +1269,6 @@ ds1685_rtc_probe(struct platform_device *pdev)
> /* See if the platform doesn't support UIE. */
> if (pdata->uie_unsupported)
> rtc_dev->uie_unsupported = 1;
> - rtc->uie_unsupported = pdata->uie_unsupported;
>
> rtc->dev = rtc_dev;
>
> diff --git a/include/linux/rtc/ds1685.h b/include/linux/rtc/ds1685.h
> index 43aec568ba7c..b9671d00d964 100644
> --- a/include/linux/rtc/ds1685.h
> +++ b/include/linux/rtc/ds1685.h
> @@ -43,13 +43,10 @@ struct ds1685_priv {
> struct rtc_device *dev;
> void __iomem *regs;
> u32 regstep;
> - resource_size_t baseaddr;
> size_t size;
> int irq_num;
> bool bcd_mode;
> bool no_irq;
> - bool uie_unsupported;
> - bool alloc_io_resources;
> u8 (*read)(struct ds1685_priv *, int);
> void (*write)(struct ds1685_priv *, int, u8);
> void (*prepare_poweroff)(void);
>
Acked-by: Joshua Kinard <kumba@gentoo.org>
next prev parent reply other threads:[~2019-10-12 22:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 15:05 [PATCH 1/3] rts: ds1685: remove not needed fields from private struct Thomas Bogendoerfer
2019-10-11 15:05 ` [PATCH 2/3] rtc: ds1685: use devm_platform_ioremap_resource helper Thomas Bogendoerfer
2019-10-12 22:49 ` Joshua Kinard
2019-10-14 15:51 ` Alexandre Belloni
2019-10-11 15:05 ` [PATCH 3/3] rtc: ds1685: add indirect access method and remove plat_read/plat_write Thomas Bogendoerfer
2019-10-12 23:22 ` Joshua Kinard
2019-10-14 21:20 ` Thomas Bogendoerfer
2019-10-12 22:41 ` Joshua Kinard [this message]
2019-10-14 15:50 ` [PATCH 1/3] rts: ds1685: remove not needed fields from private struct Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00fbd208-128d-f86d-d9db-6caa1ecc381d@gentoo.org \
--to=kumba@gentoo.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=tbogendoerfer@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).