From: Guenter Roeck <linux@roeck-us.net>
To: Yuehaibing <yuehaibing@huawei.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: a.zummo@towertech.it, bruno.thomsen@gmail.com,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] rtc: pcf2127: Fix build error without CONFIG_WATCHDOG_CORE
Date: Mon, 26 Aug 2019 06:20:54 -0700 [thread overview]
Message-ID: <01a2b6b2-eb15-1b40-1edc-de122bbdb5a2@roeck-us.net> (raw)
In-Reply-To: <4b608c55-2541-30cf-ad88-c19a5c0cc84f@huawei.com>
On 8/26/19 1:12 AM, Yuehaibing wrote:
>
>
> On 2019/8/23 22:05, Alexandre Belloni wrote:
>> On 23/08/2019 20:45:53+0800, YueHaibing wrote:
>>> If WATCHDOG_CORE is not set, build fails:
>>>
>>> drivers/rtc/rtc-pcf2127.o: In function `pcf2127_probe.isra.6':
>>> drivers/rtc/rtc-pcf2127.c:478: undefined reference to `devm_watchdog_register_device'
>>>
>>> Add WATCHDOG_CORE Kconfig dependency to fix this.
>>>
>>> Reported-by: Hulk Robot <hulkci@huawei.com>
>>> Fixes: bbc597561ce1 ("rtc: pcf2127: add watchdog feature support")
>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>>> ---
>>> drivers/rtc/Kconfig | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
>>> index 25af63d..9dce7dc 100644
>>> --- a/drivers/rtc/Kconfig
>>> +++ b/drivers/rtc/Kconfig
>>> @@ -886,6 +886,8 @@ config RTC_DRV_DS3232_HWMON
>>> config RTC_DRV_PCF2127
>>> tristate "NXP PCF2127"
>>> depends on RTC_I2C_AND_SPI
>>> + depends on WATCHDOG
>>
>> Definitively not, I fixed it that way:
>> + select WATCHDOG_CORE if WATCHDOG
>
>
> No, this still fails while WATCHDOG is not set
>
Correct, there are no dummy functions for watchdog device registration.
There would have to be conditional code in the driver if the watchdog
is supposed to be optional.
Guenter
next prev parent reply other threads:[~2019-08-26 13:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 12:45 [PATCH -next] rtc: pcf2127: Fix build error without CONFIG_WATCHDOG_CORE YueHaibing
2019-08-23 13:38 ` Guenter Roeck
2019-08-23 14:05 ` Alexandre Belloni
2019-08-26 8:12 ` Yuehaibing
2019-08-26 13:20 ` Guenter Roeck [this message]
2019-08-26 18:13 ` Bruno Thomsen
2019-08-26 18:46 ` Guenter Roeck
2019-08-28 17:18 ` Randy Dunlap
2019-08-29 14:04 ` Bruno Thomsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01a2b6b2-eb15-1b40-1edc-de122bbdb5a2@roeck-us.net \
--to=linux@roeck-us.net \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=bruno.thomsen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).