From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 15/41] rtc: max77686: Convert to platform remove callback returning void
Date: Sun, 5 Mar 2023 10:50:59 +0100 [thread overview]
Message-ID: <0e39d5e8-2206-8615-cb91-c65fdd0a2a17@linaro.org> (raw)
In-Reply-To: <20230304133028.2135435-16-u.kleine-koenig@pengutronix.de>
On 04/03/2023 14:30, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/rtc/rtc-max77686.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-05 9:51 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-04 13:29 [PATCH 00/41] rtc: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-04 13:29 ` [PATCH 01/41] rtc: 88pm80x: " Uwe Kleine-König
2023-03-04 13:29 ` [PATCH 02/41] rtc: 88pm860x: " Uwe Kleine-König
2023-03-04 13:29 ` [PATCH 03/41] rtc: ab8500: " Uwe Kleine-König
2023-03-07 13:35 ` Linus Walleij
2023-03-04 13:29 ` [PATCH 04/41] rtc: ac100: " Uwe Kleine-König
2023-03-04 13:29 ` [PATCH 05/41] rtc: asm9260: " Uwe Kleine-König
2023-03-04 13:29 ` [PATCH 06/41] rtc: at91sam9: " Uwe Kleine-König
2023-03-06 11:55 ` Claudiu.Beznea
2023-03-04 13:29 ` [PATCH 07/41] rtc: brcmstb-waketimer: " Uwe Kleine-König
2023-03-04 13:29 ` [PATCH 08/41] rtc: cadence: " Uwe Kleine-König
2023-03-04 13:29 ` [PATCH 09/41] rtc: cmos: " Uwe Kleine-König
2023-03-04 13:29 ` [PATCH 10/41] rtc: cros-ec: " Uwe Kleine-König
2023-03-07 5:30 ` Tzung-Bi Shih
2023-03-04 13:29 ` [PATCH 11/41] rtc: ds1685: " Uwe Kleine-König
2023-03-06 19:43 ` Joshua Kinard
2023-03-06 21:22 ` Uwe Kleine-König
2023-03-07 2:09 ` Joshua Kinard
2023-03-07 8:11 ` Uwe Kleine-König
2023-03-08 16:20 ` Joshua Kinard
2023-03-08 16:47 ` Uwe Kleine-König
2023-03-13 15:08 ` Joshua Kinard
2023-03-04 13:29 ` [PATCH 12/41] rtc: ftrtc010: " Uwe Kleine-König
2023-03-07 13:35 ` Linus Walleij
2023-03-04 13:30 ` [PATCH 13/41] rtc: hid-sensor-time: " Uwe Kleine-König
2023-03-04 13:30 ` [PATCH 14/41] rtc: lpc24xx: " Uwe Kleine-König
2023-03-04 13:30 ` [PATCH 15/41] rtc: max77686: " Uwe Kleine-König
2023-03-05 9:50 ` Krzysztof Kozlowski [this message]
2023-03-04 13:30 ` [PATCH 16/41] rtc: mc13xxx: " Uwe Kleine-König
2023-03-04 13:30 ` [PATCH 17/41] rtc: mpc5121: " Uwe Kleine-König
2023-03-04 13:30 ` [PATCH 18/41] rtc: mpfs: " Uwe Kleine-König
2023-03-04 13:47 ` Conor Dooley
2023-03-04 13:30 ` [PATCH 19/41] rtc: mt7622: " Uwe Kleine-König
2023-03-04 13:30 ` [PATCH 20/41] rtc: mxc_v2: " Uwe Kleine-König
2023-03-04 13:30 ` [PATCH 21/41] rtc: omap: " Uwe Kleine-König
2023-03-04 13:30 ` [PATCH 22/41] rtc: palmas: " Uwe Kleine-König
2023-03-04 13:30 ` [PATCH 23/41] rtc: pcf50633: " Uwe Kleine-König
2023-03-04 13:30 ` [PATCH 24/41] rtc: pic32: " Uwe Kleine-König
2023-03-04 13:30 ` [PATCH 25/41] rtc: pm8xxx: " Uwe Kleine-König
2023-03-04 13:30 ` [PATCH 26/41] rtc: rc5t583: " Uwe Kleine-König
2023-03-04 13:30 ` [PATCH 27/41] rtc: rtd119x: " Uwe Kleine-König
2023-03-04 13:30 ` [PATCH 28/41] rtc: rzn1: " Uwe Kleine-König
2023-03-06 8:12 ` Miquel Raynal
2023-03-04 13:30 ` [PATCH 29/41] rtc: s3c: " Uwe Kleine-König
2023-03-04 13:30 ` [PATCH 30/41] rtc: sa1100: " Uwe Kleine-König
2023-03-04 13:30 ` [PATCH 31/41] rtc: spear: " Uwe Kleine-König
2023-03-04 13:30 ` [PATCH 32/41] rtc: stm32: " Uwe Kleine-König
2023-03-04 13:30 ` [PATCH 33/41] rtc: stmp3xxx: " Uwe Kleine-König
2023-03-04 13:30 ` [PATCH 34/41] rtc: sunplus: " Uwe Kleine-König
2023-03-04 13:30 ` [PATCH 35/41] rtc: tegra: " Uwe Kleine-König
2023-03-04 13:30 ` [PATCH 36/41] rtc: tps6586x: " Uwe Kleine-König
2023-03-04 13:30 ` [PATCH 37/41] rtc: twl: " Uwe Kleine-König
2023-03-04 13:30 ` [PATCH 38/41] rtc: vt8500: " Uwe Kleine-König
2023-03-04 13:30 ` [PATCH 39/41] rtc: wm8350: " Uwe Kleine-König
2023-03-06 9:37 ` Charles Keepax
2023-03-04 13:30 ` [PATCH 40/41] rtc: xgene: " Uwe Kleine-König
2023-03-04 13:30 ` [PATCH 41/41] rtc: zynqmp: " Uwe Kleine-König
2023-03-14 9:05 ` [PATCH 00/41] rtc: " Naresh Kamboju
2023-03-17 22:09 ` Alexandre Belloni
2023-05-08 3:45 ` patchwork-bot+chrome-platform
2023-05-08 3:56 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e39d5e8-2206-8615-cb91-c65fdd0a2a17@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=cw00.choi@samsung.com \
--cc=kernel@pengutronix.de \
--cc=linux-rtc@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).