From: Trent Piepho <tpiepho@impinj.com>
To: "leoyang.li@nxp.com" <leoyang.li@nxp.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"a.zummo@towertech.it" <a.zummo@towertech.it>,
"biwen.li@nxp.com" <biwen.li@nxp.com>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Cc: "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [1/3] rtc/fsl: support flextimer for lx2160a
Date: Fri, 23 Aug 2019 16:56:28 +0000 [thread overview]
Message-ID: <1566579388.5029.8.camel@impinj.com> (raw)
In-Reply-To: <20190823095740.12280-1-biwen.li@nxp.com>
On Fri, 2019-08-23 at 17:57 +0800, Biwen Li wrote:
> The patch supports flextimer for lx2160a
>
> Signed-off-by: Biwen Li <biwen.li@nxp.com>
> ---
> drivers/rtc/rtc-fsl-ftm-alarm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/rtc/rtc-fsl-ftm-alarm.c b/drivers/rtc/rtc-fsl-
> ftm-alarm.c
> index 4f7259c2d6a3..2b81525f6db8 100644
> --- a/drivers/rtc/rtc-fsl-ftm-alarm.c
> +++ b/drivers/rtc/rtc-fsl-ftm-alarm.c
> @@ -313,6 +313,7 @@ static const struct of_device_id ftm_rtc_match[]
> = {
> { .compatible = "fsl,ls1088a-ftm-alarm", },
> { .compatible = "fsl,ls208xa-ftm-alarm", },
> { .compatible = "fsl,ls1028a-ftm-alarm", },
> + { .compatible = "fsl,lx2160a-ftm-alarm", },
> { },
> };
>
Since there's no data associated with each compatible, it doesn't seem
like there's any need to add a new one.
What's normally done is add two compatibles in the dts, the base
version and the specific version, e.g.:
+ rcpm: rcpm@1e34040 {
+ compatible = "fsl,lx2160a-rcpm", "fsl,qoriq-cpm-2.1+";
Or in this case, compatible = "fsl,lx2160a-ftm-alarm", "fsl,ls1088a-ftm-alarm";
Then there's no need to add to the driver list.
next prev parent reply other threads:[~2019-08-23 16:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 9:57 [1/3] rtc/fsl: support flextimer for lx2160a Biwen Li
2019-08-23 9:57 ` [2/3] arm64: dts: lx2160a: add ftm_alarm0 DT node Biwen Li
2019-08-23 9:57 ` [3/3] rtc/fsl: support flextimer for SoC LS1021A (ARM32) Biwen Li
2019-08-23 12:43 ` [1/3] rtc/fsl: support flextimer for lx2160a Alexandre Belloni
2019-08-23 14:25 ` Alexandre Belloni
2019-08-26 3:30 ` [EXT] " Biwen Li
2019-08-23 16:56 ` Trent Piepho [this message]
2019-08-26 3:37 ` Biwen Li
2019-08-26 10:10 ` Alexandre Belloni
2019-08-26 10:37 ` Biwen Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1566579388.5029.8.camel@impinj.com \
--to=tpiepho@impinj.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=biwen.li@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).