From: zhong jiang <zhongjiang@huawei.com>
To: <tony@atomide.com>, <udeep.dutt@intel.com>,
<ashutosh.dixit@intel.com>, <gregkh@linuxfoundation.org>,
<kishon@ti.com>, <jonathanh@nvidia.com>, <a.zummo@towertech.it>,
<alexandre.belloni@bootlin.com>
Cc: <zhongjiang@huawei.com>, <linux-kernel@vger.kernel.org>,
<linux-rtc@vger.kernel.org>, <arnd@arndb.de>,
<lorenzo.pieralisi@arm.com>
Subject: [PATCH 4/4] rtc: ds1347: Use PTR_ERR_OR_ZERO rather than its implementation
Date: Thu, 5 Sep 2019 14:43:15 +0800 [thread overview]
Message-ID: <1567665795-5901-5-git-send-email-zhongjiang@huawei.com> (raw)
In-Reply-To: <1567665795-5901-1-git-send-email-zhongjiang@huawei.com>
PTR_ERR_OR_ZERO contains if(IS_ERR(...)) + PTR_ERR. It is better to
use it directly. hence just replace it.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
drivers/rtc/rtc-ds1347.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/rtc/rtc-ds1347.c b/drivers/rtc/rtc-ds1347.c
index d392a7b..5a64eea 100644
--- a/drivers/rtc/rtc-ds1347.c
+++ b/drivers/rtc/rtc-ds1347.c
@@ -151,10 +151,7 @@ static int ds1347_probe(struct spi_device *spi)
rtc = devm_rtc_device_register(&spi->dev, "ds1347",
&ds1347_rtc_ops, THIS_MODULE);
- if (IS_ERR(rtc))
- return PTR_ERR(rtc);
-
- return 0;
+ return PTR_ERR_OR_ZERO(rtc);
}
static struct spi_driver ds1347_driver = {
--
1.7.12.4
next prev parent reply other threads:[~2019-09-05 6:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 6:43 [PATCH 0/4] Use PTR_ERR_OR_ZERO directly zhong jiang
2019-09-05 6:43 ` [PATCH 1/4] bus: ti-sysc: Use PTR_ERR_OR_ZERO rather than its implementation zhong jiang
2019-09-05 6:43 ` [PATCH 2/4] misc: mic: " zhong jiang
2019-09-05 6:43 ` [PATCH 3/4] phy: tegra: " zhong jiang
2019-09-05 6:43 ` zhong jiang [this message]
2019-09-05 7:39 ` [PATCH 4/4] rtc: ds1347: " Alexandre Belloni
2019-09-05 8:18 ` zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1567665795-5901-5-git-send-email-zhongjiang@huawei.com \
--to=zhongjiang@huawei.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=ashutosh.dixit@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=tony@atomide.com \
--cc=udeep.dutt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).