From: Anson Huang <Anson.Huang@nxp.com>
To: shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com,
dmitry.torokhov@gmail.com, a.zummo@towertech.it,
alexandre.belloni@bootlin.com, rui.zhang@intel.com,
daniel.lezcano@linaro.org, amit.kucheria@verdurent.com,
wim@linux-watchdog.org, linux@roeck-us.net,
daniel.baluta@nxp.com, linux@rempel-privat.de,
gregkh@linuxfoundation.org, tglx@linutronix.de,
m.felsch@pengutronix.de, andriy.shevchenko@linux.intel.com,
arnd@arndb.de, robh@kernel.org, yuehaibing@huawei.com,
ronald@innovation.ch, krzk@kernel.org, leonard.crestez@nxp.com,
aisheng.dong@nxp.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
linux-rtc@vger.kernel.org, linux-pm@vger.kernel.org,
linux-watchdog@vger.kernel.org
Cc: Linux-imx@nxp.com
Subject: [PATCH V2 5/7] input: keyboard: imx_sc_key: Fix build warning for !CONFIG_IMX_SCU case
Date: Sat, 7 Mar 2020 09:25:57 +0800 [thread overview]
Message-ID: <1583544359-515-5-git-send-email-Anson.Huang@nxp.com> (raw)
In-Reply-To: <1583544359-515-1-git-send-email-Anson.Huang@nxp.com>
Fix below build warning when COMPILE_TEST is enabled while IMX_SCU is not:
drivers/input/keyboard/imx_sc_key.c: In function ‘imx_sc_check_for_events’:
drivers/input/keyboard/imx_sc_key.c:87:27: warning: ‘msg.state’ is used
uninitialized in this function [-Wuninitialized]
state = (bool)(msg.state & 0xff);
^
AR drivers/input/keyboard/built-in.a
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
new patch.
---
drivers/input/keyboard/imx_sc_key.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/keyboard/imx_sc_key.c b/drivers/input/keyboard/imx_sc_key.c
index 9f809ae..26a12fb 100644
--- a/drivers/input/keyboard/imx_sc_key.c
+++ b/drivers/input/keyboard/imx_sc_key.c
@@ -72,6 +72,7 @@ static void imx_sc_check_for_events(struct work_struct *work)
hdr->func = IMX_SC_MISC_FUNC_GET_BUTTON_STATUS;
hdr->size = 1;
+ msg.state = 0;
error = imx_scu_call_rpc(priv->key_ipc_handle, &msg, true);
if (error) {
dev_err(&input->dev, "read imx sc key failed, error %d\n", error);
--
2.7.4
next prev parent reply other threads:[~2020-03-07 1:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-07 1:25 [PATCH V2 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU case Anson Huang
2020-03-07 1:25 ` [PATCH V2 2/7] firmware: imx: add COMPILE_TEST support Anson Huang
2020-03-07 1:25 ` [PATCH V2 3/7] rtc: add COMPILE_TEST support for i.MX SC RTC Anson Huang
2020-03-07 1:25 ` [PATCH V2 4/7] input: keyboard: add COMPILE_TEST support for KEYBOARD_IMX_SC_KEY Anson Huang
2020-03-07 1:25 ` Anson Huang [this message]
2020-03-07 1:25 ` [PATCH V2 6/7] watchdog: add COMPILE_TEST support for IMX_SC_WDT Anson Huang
2020-03-07 1:25 ` [PATCH V2 7/7] thermal: add COMPILE_TEST support for IMX_SC_THERMAL Anson Huang
2020-03-09 0:00 ` [PATCH V2 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU case Guenter Roeck
2020-03-09 0:45 ` Anson Huang
2020-03-16 0:28 ` Shawn Guo
2020-03-16 0:54 ` Guenter Roeck
2020-03-16 1:12 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1583544359-515-5-git-send-email-Anson.Huang@nxp.com \
--to=anson.huang@nxp.com \
--cc=Linux-imx@nxp.com \
--cc=a.zummo@towertech.it \
--cc=aisheng.dong@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=amit.kucheria@verdurent.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=daniel.baluta@nxp.com \
--cc=daniel.lezcano@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=linux@roeck-us.net \
--cc=m.felsch@pengutronix.de \
--cc=robh@kernel.org \
--cc=ronald@innovation.ch \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
--cc=wim@linux-watchdog.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).