From: Yingjoe Chen <yingjoe.chen@mediatek.com>
To: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
"Alessandro Zummo" <a.zummo@towertech.it>,
Josef Friedl <josef.friedl@speed.at>,
"Nicolas Boichat" <drinkcat@chromium.org>,
<srv_heupstream@mediatek.com>,
"Frank Wunderlich" <frank-w@public-files.de>,
Ran Bi <ran.bi@mediatek.com>,
"Sean Wang" <sean.wang@mediatek.com>,
Sebastian Reichel <sre@kernel.org>,
<linux-kernel@vger.kernel.org>,
Richard Fontana <rfontana@redhat.com>,
<devicetree@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-pm@vger.kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
Eddie Huang <eddie.huang@mediatek.com>,
<linux-rtc@vger.kernel.org>
Subject: Re: [PATCH v9 4/5] rtc: mt6397: Add support for the MediaTek MT6358 RTC
Date: Wed, 11 Mar 2020 11:24:51 +0800 [thread overview]
Message-ID: <1583897091.14612.1.camel@mtksdaap41> (raw)
In-Reply-To: <1583835040-19157-5-git-send-email-hsin-hsiung.wang@mediatek.com>
On Tue, 2020-03-10 at 18:10 +0800, Hsin-Hsiung Wang wrote:
> From: Ran Bi <ran.bi@mediatek.com>
>
> This add support for the MediaTek MT6358 RTC. Driver using
> compatible data to store different RTC_WRTGR address offset.
> This replace RTC_WRTGR to RTC_WRTGR_MT6323 in mt6323-poweroff
> driver which only needed by armv7 CPU without ATF.
>
> Signed-off-by: Ran Bi <ran.bi@mediatek.com>
> Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
> ---
<...>
> diff --git a/include/linux/mfd/mt6397/rtc.h b/include/linux/mfd/mt6397/rtc.h
> index 7dfb63b..3dc48e8 100644
> --- a/include/linux/mfd/mt6397/rtc.h
> +++ b/include/linux/mfd/mt6397/rtc.h
<...>
> +
> +static const struct mtk_rtc_data mt6358_rtc_data = {
> + .wrtgr = RTC_WRTGR_MT6358,
> +};
> +
> +static const struct mtk_rtc_data mt6397_rtc_data = {
> + .wrtgr = RTC_WRTGR_MT6397,
> };
Hi,
mt6323-poweroff.c doesn't need these _rtc_data. Please put them in
rtc-mt6397.c
Joe.C
next prev parent reply other threads:[~2020-03-11 3:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 10:10 [PATCH v9 0/5] Add Support for MediaTek PMIC MT6358 Hsin-Hsiung Wang
2020-03-10 10:10 ` [PATCH v9 1/5] mfd: mt6397: modify suspend/resume behavior Hsin-Hsiung Wang
2020-03-10 10:10 ` [PATCH v9 2/5] dt-bindings: mfd: Add compatible for the MediaTek MT6358 PMIC Hsin-Hsiung Wang
2020-03-10 10:10 ` [PATCH v9 3/5] mfd: Add support " Hsin-Hsiung Wang
2020-03-11 3:24 ` Nicolas Boichat
2020-03-11 3:48 ` Hsin-hsiung Wang
2020-03-10 10:10 ` [PATCH v9 4/5] rtc: mt6397: Add support for the MediaTek MT6358 RTC Hsin-Hsiung Wang
2020-03-11 3:24 ` Yingjoe Chen [this message]
2020-03-10 10:10 ` [PATCH v9 5/5] arm64: dts: mt6358: add PMIC MT6358 related nodes Hsin-Hsiung Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1583897091.14612.1.camel@mtksdaap41 \
--to=yingjoe.chen@mediatek.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=eddie.huang@mediatek.com \
--cc=frank-w@public-files.de \
--cc=hsin-hsiung.wang@mediatek.com \
--cc=josef.friedl@speed.at \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=ran.bi@mediatek.com \
--cc=rfontana@redhat.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=sre@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).