From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F8C2C10DCE for ; Wed, 18 Mar 2020 09:54:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0227220724 for ; Wed, 18 Mar 2020 09:54:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="vZnr3RJu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726933AbgCRJyR (ORCPT ); Wed, 18 Mar 2020 05:54:17 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:31581 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726310AbgCRJyR (ORCPT ); Wed, 18 Mar 2020 05:54:17 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1584525257; h=Message-Id: Date: Subject: Cc: To: From: Sender; bh=78NW6MNOkJx39ThDhsqaw3fGUuX3C/kjkgZ8D3avYQo=; b=vZnr3RJu+jWo3ATCqIMzipjPLf7W+fCgur8vnEXR7UhstNRCHfoSL81UYCIxgb6xRMCQFb3F Y1gZRcvFk7hFgtKpmn/VkHNzsOk9tI4NOgkDc2PrtTFDecTCNTLFGjVTxOYlWtnSffGs+Z08 z2qIIZ2jvjPGZ1POJ7R3rfVms7Y= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyJhNWYyNyIsICJsaW51eC1ydGNAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e71efbc.7f1bdb071068-smtp-out-n05; Wed, 18 Mar 2020 09:54:04 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 50DC4C432C2; Wed, 18 Mar 2020 09:54:03 +0000 (UTC) Received: from maggarwa-linux.qualcomm.com (blr-c-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: maggarwa) by smtp.codeaurora.org (Postfix) with ESMTPSA id E171FC433CB; Wed, 18 Mar 2020 09:54:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E171FC433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=maggarwa@codeaurora.org From: Mohit Aggarwal To: a.zummo@towertech.it, alexandre.belloni@bootlin.com Cc: Mohit Aggarwal , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] rtc-pm8xxx: Clear Alarm register on resume Date: Wed, 18 Mar 2020 15:23:38 +0530 Message-Id: <1584525218-14719-1-git-send-email-maggarwa@codeaurora.org> X-Mailer: git-send-email 1.9.1 Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org Currently, alarm register is not cleared on resume leading to reboot during power off charging mode. Signed-off-by: Mohit Aggarwal --- drivers/rtc/rtc-pm8xxx.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c index bbe013f..bfcd878 100644 --- a/drivers/rtc/rtc-pm8xxx.c +++ b/drivers/rtc/rtc-pm8xxx.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/* Copyright (c) 2010-2011, 2019, The Linux Foundation. All rights reserved. */ +/* Copyright (c) 2010-2011, 2019-2020, The Linux Foundation. All rights reserved. */ #include #include @@ -301,6 +301,7 @@ static int pm8xxx_rtc_alarm_irq_enable(struct device *dev, unsigned int enable) struct pm8xxx_rtc *rtc_dd = dev_get_drvdata(dev); const struct pm8xxx_rtc_regs *regs = rtc_dd->regs; unsigned int ctrl_reg; + u8 value[NUM_8_BIT_RTC_REGS] = {0}; spin_lock_irqsave(&rtc_dd->ctrl_reg_lock, irq_flags); @@ -319,6 +320,16 @@ static int pm8xxx_rtc_alarm_irq_enable(struct device *dev, unsigned int enable) goto rtc_rw_fail; } + /* Clear Alarm register */ + if (!enable) { + rc = regmap_bulk_write(rtc_dd->regmap, regs->alarm_rw, value, + sizeof(value)); + if (rc) { + dev_err(dev, "Write to RTC ALARM register failed\n"); + goto rtc_rw_fail; + } + } + rtc_rw_fail: spin_unlock_irqrestore(&rtc_dd->ctrl_reg_lock, irq_flags); return rc; -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project