From: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com> To: Lee Jones <lee.jones@linaro.org>, Rob Herring <robh+dt@kernel.org>, Matthias Brugger <matthias.bgg@gmail.com>, Alexandre Belloni <alexandre.belloni@bootlin.com> Cc: Nicolas Boichat <drinkcat@chromium.org>, Mark Rutland <mark.rutland@arm.com>, Sean Wang <sean.wang@mediatek.com>, Sebastian Reichel <sre@kernel.org>, Eddie Huang <eddie.huang@mediatek.com>, Alessandro Zummo <a.zummo@towertech.it>, Kate Stewart <kstewart@linuxfoundation.org>, Richard Fontana <rfontana@redhat.com>, Frank Wunderlich <frank-w@public-files.de>, Josef Friedl <josef.friedl@speed.at>, Thomas Gleixner <tglx@linutronix.de>, Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>, Ran Bi <ran.bi@mediatek.com>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-mediatek@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>, <linux-rtc@vger.kernel.org>, <srv_heupstream@mediatek.com> Subject: [PATCH v11 4/5] rtc: mt6397: Add support for the MediaTek MT6358 RTC Date: Tue, 31 Mar 2020 12:07:36 +0800 [thread overview] Message-ID: <1585627657-3265-5-git-send-email-hsin-hsiung.wang@mediatek.com> (raw) In-Reply-To: <1585627657-3265-1-git-send-email-hsin-hsiung.wang@mediatek.com> From: Ran Bi <ran.bi@mediatek.com> This add support for the MediaTek MT6358 RTC. Driver using compatible data to store different RTC_WRTGR address offset. This replace RTC_WRTGR to RTC_WRTGR_MT6323 in mt6323-poweroff driver which only needed by armv7 CPU without ATF. Signed-off-by: Ran Bi <ran.bi@mediatek.com> Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com> --- drivers/power/reset/mt6323-poweroff.c | 2 +- drivers/rtc/rtc-mt6397.c | 23 +++++++++++++++++++---- include/linux/mfd/mt6397/rtc.h | 9 ++++++++- 3 files changed, 28 insertions(+), 6 deletions(-) diff --git a/drivers/power/reset/mt6323-poweroff.c b/drivers/power/reset/mt6323-poweroff.c index 1caf43d..0532803 100644 --- a/drivers/power/reset/mt6323-poweroff.c +++ b/drivers/power/reset/mt6323-poweroff.c @@ -30,7 +30,7 @@ static void mt6323_do_pwroff(void) int ret; regmap_write(pwrc->regmap, pwrc->base + RTC_BBPU, RTC_BBPU_KEY); - regmap_write(pwrc->regmap, pwrc->base + RTC_WRTGR, 1); + regmap_write(pwrc->regmap, pwrc->base + RTC_WRTGR_MT6323, 1); ret = regmap_read_poll_timeout(pwrc->regmap, pwrc->base + RTC_BBPU, val, diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c index cda238d..7f3dfd2 100644 --- a/drivers/rtc/rtc-mt6397.c +++ b/drivers/rtc/rtc-mt6397.c @@ -9,6 +9,7 @@ #include <linux/mfd/mt6397/core.h> #include <linux/module.h> #include <linux/mutex.h> +#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/regmap.h> #include <linux/rtc.h> @@ -20,7 +21,7 @@ static int mtk_rtc_write_trigger(struct mt6397_rtc *rtc) int ret; u32 data; - ret = regmap_write(rtc->regmap, rtc->addr_base + RTC_WRTGR, 1); + ret = regmap_write(rtc->regmap, rtc->addr_base + rtc->data->wrtgr, 1); if (ret < 0) return ret; @@ -269,6 +270,8 @@ static int mtk_rtc_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); rtc->addr_base = res->start; + rtc->data = of_device_get_match_data(&pdev->dev); + rtc->irq = platform_get_irq(pdev, 0); if (rtc->irq < 0) return rtc->irq; @@ -325,10 +328,22 @@ static int mt6397_rtc_resume(struct device *dev) static SIMPLE_DEV_PM_OPS(mt6397_pm_ops, mt6397_rtc_suspend, mt6397_rtc_resume); +static const struct mtk_rtc_data mt6358_rtc_data = { + .wrtgr = RTC_WRTGR_MT6358, +}; + +static const struct mtk_rtc_data mt6397_rtc_data = { + .wrtgr = RTC_WRTGR_MT6397, +}; + static const struct of_device_id mt6397_rtc_of_match[] = { - { .compatible = "mediatek,mt6323-rtc", }, - { .compatible = "mediatek,mt6397-rtc", }, - { } + { .compatible = "mediatek,mt6323-rtc", + .data = &mt6397_rtc_data, }, + { .compatible = "mediatek,mt6358-rtc", + .data = &mt6358_rtc_data, }, + { .compatible = "mediatek,mt6397-rtc", + .data = &mt6397_rtc_data, }, + {} }; MODULE_DEVICE_TABLE(of, mt6397_rtc_of_match); diff --git a/include/linux/mfd/mt6397/rtc.h b/include/linux/mfd/mt6397/rtc.h index 7dfb63b..6200f3b 100644 --- a/include/linux/mfd/mt6397/rtc.h +++ b/include/linux/mfd/mt6397/rtc.h @@ -18,7 +18,9 @@ #define RTC_BBPU_CBUSY BIT(6) #define RTC_BBPU_KEY (0x43 << 8) -#define RTC_WRTGR 0x003c +#define RTC_WRTGR_MT6358 0x3a +#define RTC_WRTGR_MT6397 0x3c +#define RTC_WRTGR_MT6323 RTC_WRTGR_MT6397 #define RTC_IRQ_STA 0x0002 #define RTC_IRQ_STA_AL BIT(0) @@ -65,6 +67,10 @@ #define MTK_RTC_POLL_DELAY_US 10 #define MTK_RTC_POLL_TIMEOUT (jiffies_to_usecs(HZ)) +struct mtk_rtc_data { + u32 wrtgr; +}; + struct mt6397_rtc { struct device *dev; struct rtc_device *rtc_dev; @@ -74,6 +80,7 @@ struct mt6397_rtc { struct regmap *regmap; int irq; u32 addr_base; + const struct mtk_rtc_data *data; }; #endif /* _LINUX_MFD_MT6397_RTC_H_ */ -- 2.6.4
next prev parent reply other threads:[~2020-03-31 4:07 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-31 4:07 [PATCH v11 0/5] Add Support for MediaTek PMIC MT6358 Hsin-Hsiung Wang 2020-03-31 4:07 ` [PATCH v11 1/5] mfd: mt6397: modify suspend/resume behavior Hsin-Hsiung Wang 2020-03-31 4:07 ` [PATCH v11 2/5] dt-bindings: mfd: Add compatible for the MediaTek MT6358 PMIC Hsin-Hsiung Wang 2020-03-31 4:07 ` [PATCH v11 3/5] mfd: Add support " Hsin-Hsiung Wang 2020-03-31 7:36 ` Nicolas Boichat 2020-03-31 8:28 ` Hsin-hsiung Wang 2020-03-31 4:07 ` Hsin-Hsiung Wang [this message] 2020-03-31 7:38 ` [PATCH v11 4/5] rtc: mt6397: Add support for the MediaTek MT6358 RTC Nicolas Boichat 2020-03-31 8:06 ` Alexandre Belloni 2020-04-05 0:43 ` Sebastian Reichel 2020-04-07 4:01 ` Yingjoe Chen 2020-03-31 4:07 ` [PATCH v11 5/5] arm64: dts: mt6358: add PMIC MT6358 related nodes Hsin-Hsiung Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1585627657-3265-5-git-send-email-hsin-hsiung.wang@mediatek.com \ --to=hsin-hsiung.wang@mediatek.com \ --cc=a.zummo@towertech.it \ --cc=alexandre.belloni@bootlin.com \ --cc=devicetree@vger.kernel.org \ --cc=drinkcat@chromium.org \ --cc=eddie.huang@mediatek.com \ --cc=frank-w@public-files.de \ --cc=josef.friedl@speed.at \ --cc=kstewart@linuxfoundation.org \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-rtc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=matthias.bgg@gmail.com \ --cc=ran.bi@mediatek.com \ --cc=rfontana@redhat.com \ --cc=robh+dt@kernel.org \ --cc=sean.wang@mediatek.com \ --cc=sre@kernel.org \ --cc=srv_heupstream@mediatek.com \ --cc=tglx@linutronix.de \ --subject='Re: [PATCH v11 4/5] rtc: mt6397: Add support for the MediaTek MT6358 RTC' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).