linux-rtc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hsin-hsiung Wang <hsin-hsiung.wang@mediatek.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	<linux-kernel@vger.kernel.org>,
	"Richard Fontana" <rfontana@redhat.com>,
	<linux-rtc@vger.kernel.org>,
	Nicolas Boichat <drinkcat@chromium.org>,
	<linux-pm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	Frank Wunderlich <frank-w@public-files.de>,
	Ran Bi <ran.bi@mediatek.com>, Sean Wang <sean.wang@mediatek.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	<linux-mediatek@lists.infradead.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Eddie Huang <eddie.huang@mediatek.com>,
	<linux-arm-kernel@lists.infradead.org>,
	Alessandro Zummo <a.zummo@towertech.it>,
	Josef Friedl <josef.friedl@speed.at>,
	<srv_heupstream@mediatek.com>, Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCH v12 1/6] mfd: mt6397: Modify suspend/resume behavior
Date: Mon, 20 Apr 2020 19:55:12 +0800	[thread overview]
Message-ID: <1587383712.11642.0.camel@mtksdaap41> (raw)
In-Reply-To: <20200420111522.GB3612@dell>

Hi,

On Mon, 2020-04-20 at 12:15 +0100, Lee Jones wrote:
> On Mon, 20 Apr 2020, Hsin-hsiung Wang wrote:
> 
> > Hi,
> > 
> > On Thu, 2020-04-16 at 09:49 +0100, Lee Jones wrote:
> > > On Wed, 08 Apr 2020, Hsin-Hsiung Wang wrote:
> > > 
> > > > Some pmics don't need backup interrupt settings, so we change to use
> > > > pm notifier for the pmics which are necessary to store settings.
> > > > 
> > > > Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
> > > > ---
> > > >  drivers/mfd/mt6397-core.c       | 30 ------------------------------
> > > >  drivers/mfd/mt6397-irq.c        | 35 ++++++++++++++++++++++++++++++++++-
> > > >  include/linux/mfd/mt6397/core.h |  2 ++
> > > >  3 files changed, 36 insertions(+), 31 deletions(-)
> > > > 
> > > > diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> > > > index 0437c85..d2e70d8 100644
> > > > --- a/drivers/mfd/mt6397-core.c
> > > > +++ b/drivers/mfd/mt6397-core.c
> > > > @@ -100,35 +100,6 @@ static const struct mfd_cell mt6397_devs[] = {
> > > >  	}
> > > >  };
> > > >  
> > > > -#ifdef CONFIG_PM_SLEEP
> > > > -static int mt6397_irq_suspend(struct device *dev)
> > > > -{
> > > > -	struct mt6397_chip *chip = dev_get_drvdata(dev);
> > > > -
> > > > -	regmap_write(chip->regmap, chip->int_con[0], chip->wake_mask[0]);
> > > > -	regmap_write(chip->regmap, chip->int_con[1], chip->wake_mask[1]);
> > > > -
> > > > -	enable_irq_wake(chip->irq);
> > > > -
> > > > -	return 0;
> > > > -}
> > > > -
> > > > -static int mt6397_irq_resume(struct device *dev)
> > > > -{
> > > > -	struct mt6397_chip *chip = dev_get_drvdata(dev);
> > > > -
> > > > -	regmap_write(chip->regmap, chip->int_con[0], chip->irq_masks_cur[0]);
> > > > -	regmap_write(chip->regmap, chip->int_con[1], chip->irq_masks_cur[1]);
> > > > -
> > > > -	disable_irq_wake(chip->irq);
> > > > -
> > > > -	return 0;
> > > > -}
> > > > -#endif
> > > > -
> > > > -static SIMPLE_DEV_PM_OPS(mt6397_pm_ops, mt6397_irq_suspend,
> > > > -			mt6397_irq_resume);
> > > > -
> > > >  struct chip_data {
> > > >  	u32 cid_addr;
> > > >  	u32 cid_shift;
> > > > @@ -238,7 +209,6 @@ static struct platform_driver mt6397_driver = {
> > > >  	.driver = {
> > > >  		.name = "mt6397",
> > > >  		.of_match_table = of_match_ptr(mt6397_of_match),
> > > > -		.pm = &mt6397_pm_ops,
> > > >  	},
> > > >  	.id_table = mt6397_id,
> > > >  };
> > > > diff --git a/drivers/mfd/mt6397-irq.c b/drivers/mfd/mt6397-irq.c
> > > > index b2d3ce1..2924919 100644
> > > > --- a/drivers/mfd/mt6397-irq.c
> > > > +++ b/drivers/mfd/mt6397-irq.c
> > > > @@ -9,6 +9,7 @@
> > > >  #include <linux/of_irq.h>
> > > >  #include <linux/platform_device.h>
> > > >  #include <linux/regmap.h>
> > > > +#include <linux/suspend.h>
> > > >  #include <linux/mfd/mt6323/core.h>
> > > >  #include <linux/mfd/mt6323/registers.h>
> > > >  #include <linux/mfd/mt6397/core.h>
> > > > @@ -81,7 +82,7 @@ static struct irq_chip mt6397_irq_chip = {
> > > >  static void mt6397_irq_handle_reg(struct mt6397_chip *mt6397, int reg,
> > > >  				  int irqbase)
> > > >  {
> > > > -	unsigned int status;
> > > > +	unsigned int status = 0;
> > > 
> > > This looks like an unrelated change, no?
> > > 
> > 
> > It is to fix the coverity defect.
> 
> Which isn't mentioned in the commit log and doesn't have anything to
> do with this patch.  Thus it should be in a separate patch, but I'm
> not going to lose any sleep over it.
> 

Could I just add it to the commit message?
Thanks.

> > > >  	int i, irq, ret;
> > > >  
> > > >  	ret = regmap_read(mt6397->regmap, reg, &status);
> > > > @@ -128,6 +129,36 @@ static const struct irq_domain_ops mt6397_irq_domain_ops = {
> > > >  	.map = mt6397_irq_domain_map,
> > > >  };
> > > 
> > > Other than that.
> > > 
> > > For my own reference:
> > >   Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
> > > 
> > Thanks for your review. I will add it in the next version.
> > 
> 


  reply	other threads:[~2020-04-20 11:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-08  8:12 [PATCH v12 0/6] Add Support for MediaTek PMIC MT6358 Hsin-Hsiung Wang
2020-04-08  8:12 ` [PATCH v12 1/6] mfd: mt6397: Modify suspend/resume behavior Hsin-Hsiung Wang
2020-04-16  8:49   ` Lee Jones
2020-04-20 10:52     ` Hsin-hsiung Wang
2020-04-20 11:15       ` Lee Jones
2020-04-20 11:55         ` Hsin-hsiung Wang [this message]
2020-04-08  8:12 ` [PATCH v12 2/6] mfd: mt6397: Trim probe function to support different chips more cleanly Hsin-Hsiung Wang
2020-04-16  8:52   ` Lee Jones
2020-04-08  8:12 ` [PATCH v12 3/6] dt-bindings: mfd: Add compatible for the MediaTek MT6358 PMIC Hsin-Hsiung Wang
2020-04-08  8:12 ` [PATCH v12 4/6] mfd: Add support " Hsin-Hsiung Wang
2020-04-16  9:10   ` Lee Jones
2020-04-08  8:12 ` [PATCH v12 5/6] rtc: mt6397: Add support for the MediaTek MT6358 RTC Hsin-Hsiung Wang
2020-04-16  9:14   ` Lee Jones
2020-04-17  8:29     ` Ran Bi
2020-04-17  8:49       ` Ran Bi
2020-04-20  7:37         ` Lee Jones
2020-04-20  7:36       ` Lee Jones
2020-04-08  8:12 ` [PATCH v12 6/6] arm64: dts: mt6358: add PMIC MT6358 related nodes Hsin-Hsiung Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1587383712.11642.0.camel@mtksdaap41 \
    --to=hsin-hsiung.wang@mediatek.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=drinkcat@chromium.org \
    --cc=eddie.huang@mediatek.com \
    --cc=frank-w@public-files.de \
    --cc=josef.friedl@speed.at \
    --cc=kstewart@linuxfoundation.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=ran.bi@mediatek.com \
    --cc=rfontana@redhat.com \
    --cc=robh+dt@kernel.org \
    --cc=sean.wang@mediatek.com \
    --cc=sre@kernel.org \
    --cc=srv_heupstream@mediatek.com \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH v12 1/6] mfd: mt6397: Modify suspend/resume behavior' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).