* [PATCH] rtc: rx8010: rename rx8010_init_client() to rx8010_init()
@ 2020-09-17 11:46 Bartosz Golaszewski
2020-09-29 20:18 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Bartosz Golaszewski @ 2020-09-17 11:46 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni
Cc: linux-rtc, linux-kernel, Bartosz Golaszewski
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Since the switch to using regmap this function no longer takes the
I2C client struct as argument nor do we even interact with the client
anywhere other than when creating the regmap.
Rename it to a less misleading name: "rx8010_init()".
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
drivers/rtc/rtc-rx8010.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-rx8010.c b/drivers/rtc/rtc-rx8010.c
index 01e9017d4025..dca41a2a39b2 100644
--- a/drivers/rtc/rtc-rx8010.c
+++ b/drivers/rtc/rtc-rx8010.c
@@ -169,7 +169,7 @@ static int rx8010_set_time(struct device *dev, struct rtc_time *dt)
return 0;
}
-static int rx8010_init_client(struct device *dev)
+static int rx8010_init(struct device *dev)
{
struct rx8010_data *rx8010 = dev_get_drvdata(dev);
u8 ctrl[2];
@@ -391,7 +391,7 @@ static int rx8010_probe(struct i2c_client *client)
if (IS_ERR(rx8010->regs))
return PTR_ERR(rx8010->regs);
- err = rx8010_init_client(dev);
+ err = rx8010_init(dev);
if (err)
return err;
--
2.26.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: rx8010: rename rx8010_init_client() to rx8010_init()
2020-09-17 11:46 [PATCH] rtc: rx8010: rename rx8010_init_client() to rx8010_init() Bartosz Golaszewski
@ 2020-09-29 20:18 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2020-09-29 20:18 UTC (permalink / raw)
To: Bartosz Golaszewski, Alessandro Zummo
Cc: Alexandre Belloni, linux-rtc, linux-kernel, Bartosz Golaszewski
On Thu, 17 Sep 2020 13:46:56 +0200, Bartosz Golaszewski wrote:
> Since the switch to using regmap this function no longer takes the
> I2C client struct as argument nor do we even interact with the client
> anywhere other than when creating the regmap.
>
> Rename it to a less misleading name: "rx8010_init()".
Applied, thanks!
[1/1] rtc: rx8010: rename rx8010_init_client() to rx8010_init()
commit: ba1bcafb29571f525bf563972e4241998db74e98
Best regards,
--
Alexandre Belloni <alexandre.belloni@bootlin.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-29 20:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-17 11:46 [PATCH] rtc: rx8010: rename rx8010_init_client() to rx8010_init() Bartosz Golaszewski
2020-09-29 20:18 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).