From: Xiaofei Tan <tanxiaofei@huawei.com>
To: <a.zummo@towertech.it>, <alexandre.belloni@bootlin.com>
Cc: Xiaofei Tan <tanxiaofei@huawei.com>, <linux-rtc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>
Subject: [PATCH 4/6] rtc: tegra: Replace spin_lock_irqsave with spin_lock in hard IRQ
Date: Wed, 3 Feb 2021 20:39:39 +0800 [thread overview]
Message-ID: <1612355981-6764-5-git-send-email-tanxiaofei@huawei.com> (raw)
In-Reply-To: <1612355981-6764-1-git-send-email-tanxiaofei@huawei.com>
It is redundant to do irqsave and irqrestore in hardIRQ context, where
it has been in a irq-disabled context.
Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
---
drivers/rtc/rtc-tegra.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/rtc/rtc-tegra.c b/drivers/rtc/rtc-tegra.c
index 8925015..85f7ad5 100644
--- a/drivers/rtc/rtc-tegra.c
+++ b/drivers/rtc/rtc-tegra.c
@@ -232,7 +232,7 @@ static irqreturn_t tegra_rtc_irq_handler(int irq, void *data)
{
struct device *dev = data;
struct tegra_rtc_info *info = dev_get_drvdata(dev);
- unsigned long events = 0, flags;
+ unsigned long events = 0;
u32 status;
status = readl(info->base + TEGRA_RTC_REG_INTR_STATUS);
@@ -240,10 +240,10 @@ static irqreturn_t tegra_rtc_irq_handler(int irq, void *data)
/* clear the interrupt masks and status on any IRQ */
tegra_rtc_wait_while_busy(dev);
- spin_lock_irqsave(&info->lock, flags);
+ spin_lock(&info->lock);
writel(0, info->base + TEGRA_RTC_REG_INTR_MASK);
writel(status, info->base + TEGRA_RTC_REG_INTR_STATUS);
- spin_unlock_irqrestore(&info->lock, flags);
+ spin_unlock(&info->lock);
}
/* check if alarm */
--
2.8.1
next prev parent reply other threads:[~2021-02-03 12:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 12:39 [PATCH 0/6] spin lock usage optimization for RTC drivers Xiaofei Tan
2021-02-03 12:39 ` [PATCH 1/6] rtc: cmos: Replace spin_lock_irqsave with spin_lock in hard IRQ Xiaofei Tan
2021-02-03 12:39 ` [PATCH 2/6] rtc: pm8xxx: " Xiaofei Tan
2021-02-03 12:39 ` [PATCH 3/6] rtc: r7301: " Xiaofei Tan
2021-02-03 12:39 ` Xiaofei Tan [this message]
2021-02-03 12:39 ` [PATCH 5/6] rtc: mxc: " Xiaofei Tan
2021-02-03 12:39 ` [PATCH 6/6] rtc: mxc_v2: " Xiaofei Tan
2021-02-05 23:52 ` [PATCH 0/6] spin lock usage optimization for RTC drivers Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1612355981-6764-5-git-send-email-tanxiaofei@huawei.com \
--to=tanxiaofei@huawei.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linuxarm@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).