* [PATCH] rtc: vr41xx: move to use request_irq by IRQF_NO_AUTOEN flag
@ 2021-04-07 1:10 Tian Tao
2021-04-16 23:04 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Tian Tao @ 2021-04-07 1:10 UTC (permalink / raw)
To: a.zummo, alexandre.belloni; +Cc: linux-rtc, Tian Tao
disable_irq() after request_irq() still has a time gap in which
interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
disable IRQ auto-enable because of requesting.
this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
is being merged: https://lore.kernel.org/patchwork/patch/1388765/
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/rtc/rtc-vr41xx.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/rtc/rtc-vr41xx.c b/drivers/rtc/rtc-vr41xx.c
index 5a9f9ad..1a02b52 100644
--- a/drivers/rtc/rtc-vr41xx.c
+++ b/drivers/rtc/rtc-vr41xx.c
@@ -312,8 +312,8 @@ static int rtc_probe(struct platform_device *pdev)
goto err_iounmap_all;
}
- retval = devm_request_irq(&pdev->dev, aie_irq, elapsedtime_interrupt, 0,
- "elapsed_time", pdev);
+ retval = devm_request_irq(&pdev->dev, aie_irq, elapsedtime_interrupt,
+ IRQF_NO_AUTOEN, "elapsed_time", pdev);
if (retval < 0)
goto err_iounmap_all;
@@ -323,16 +323,13 @@ static int rtc_probe(struct platform_device *pdev)
goto err_iounmap_all;
}
- retval = devm_request_irq(&pdev->dev, pie_irq, rtclong1_interrupt, 0,
- "rtclong1", pdev);
+ retval = devm_request_irq(&pdev->dev, pie_irq, rtclong1_interrupt,
+ IRQF_NO_AUTOEN, "rtclong1", pdev);
if (retval < 0)
goto err_iounmap_all;
platform_set_drvdata(pdev, rtc);
- disable_irq(aie_irq);
- disable_irq(pie_irq);
-
dev_info(&pdev->dev, "Real Time Clock of NEC VR4100 series\n");
retval = devm_rtc_register_device(rtc);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-16 23:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-07 1:10 [PATCH] rtc: vr41xx: move to use request_irq by IRQF_NO_AUTOEN flag Tian Tao
2021-04-16 23:04 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).