Linux-RTC Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2] rtc: tps6586x: move to use request_irq by IRQF_NO_AUTOEN flag
@ 2021-03-15 12:51 Tian Tao
  2021-04-16 22:55 ` Alexandre Belloni
  0 siblings, 1 reply; 2+ messages in thread
From: Tian Tao @ 2021-03-15 12:51 UTC (permalink / raw)
  To: a.zummo, alexandre.belloni; +Cc: linux-rtc

request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable
because of requesting.

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
v2: Fix the problem of using wrong flags
---
 drivers/rtc/rtc-tps6586x.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/rtc/rtc-tps6586x.c b/drivers/rtc/rtc-tps6586x.c
index a980337..0eb9a0d 100644
--- a/drivers/rtc/rtc-tps6586x.c
+++ b/drivers/rtc/rtc-tps6586x.c
@@ -268,11 +268,9 @@ static int tps6586x_rtc_probe(struct platform_device *pdev)
 	rtc->rtc->start_secs = mktime64(2009, 1, 1, 0, 0, 0);
 	rtc->rtc->set_start_time = true;
 
-	irq_set_status_flags(rtc->irq, IRQ_NOAUTOEN);
-
 	ret = devm_request_threaded_irq(&pdev->dev, rtc->irq, NULL,
 				tps6586x_rtc_irq,
-				IRQF_ONESHOT,
+				IRQF_ONESHOT | IRQF_NO_AUTOEN,
 				dev_name(&pdev->dev), rtc);
 	if (ret < 0) {
 		dev_err(&pdev->dev, "request IRQ(%d) failed with ret %d\n",
-- 
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] rtc: tps6586x: move to use request_irq by IRQF_NO_AUTOEN flag
  2021-03-15 12:51 [PATCH v2] rtc: tps6586x: move to use request_irq by IRQF_NO_AUTOEN flag Tian Tao
@ 2021-04-16 22:55 ` Alexandre Belloni
  0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2021-04-16 22:55 UTC (permalink / raw)
  To: Tian Tao, a.zummo; +Cc: Alexandre Belloni, linux-rtc

On Mon, 15 Mar 2021 20:51:14 +0800, Tian Tao wrote:
> request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable
> because of requesting.

Applied, thanks!

[1/1] rtc: tps6586x: move to use request_irq by IRQF_NO_AUTOEN flag
      commit: 44db35cb9bf31163d17bee2c9748e1570b81be26

Best regards,
-- 
Alexandre Belloni <alexandre.belloni@bootlin.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-15 12:51 [PATCH v2] rtc: tps6586x: move to use request_irq by IRQF_NO_AUTOEN flag Tian Tao
2021-04-16 22:55 ` Alexandre Belloni

Linux-RTC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rtc/0 linux-rtc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rtc linux-rtc/ https://lore.kernel.org/linux-rtc \
		linux-rtc@vger.kernel.org
	public-inbox-index linux-rtc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rtc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git