* [PATCH] rtc: as3722: move to use request_irq by IRQF_NO_AUTOEN flag
@ 2021-04-06 12:34 Tian Tao
2021-04-16 22:56 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Tian Tao @ 2021-04-06 12:34 UTC (permalink / raw)
To: a.zummo, alexandre.belloni; +Cc: linux-rtc, Tian Tao
disable_irq() after request_irq() still has a time gap in which
interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
disable IRQ auto-enable because of requesting.
this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
is being merged: https://lore.kernel.org/patchwork/patch/1388765/
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/rtc/rtc-as3722.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-as3722.c b/drivers/rtc/rtc-as3722.c
index 0f21af2..3a0db97 100644
--- a/drivers/rtc/rtc-as3722.c
+++ b/drivers/rtc/rtc-as3722.c
@@ -201,14 +201,13 @@ static int as3722_rtc_probe(struct platform_device *pdev)
dev_info(&pdev->dev, "RTC interrupt %d\n", as3722_rtc->alarm_irq);
ret = devm_request_threaded_irq(&pdev->dev, as3722_rtc->alarm_irq, NULL,
- as3722_alarm_irq, IRQF_ONESHOT,
+ as3722_alarm_irq, IRQF_ONESHOT | IRQF_NO_AUTOEN,
"rtc-alarm", as3722_rtc);
if (ret < 0) {
dev_err(&pdev->dev, "Failed to request alarm IRQ %d: %d\n",
as3722_rtc->alarm_irq, ret);
return ret;
}
- disable_irq(as3722_rtc->alarm_irq);
return 0;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-16 22:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-06 12:34 [PATCH] rtc: as3722: move to use request_irq by IRQF_NO_AUTOEN flag Tian Tao
2021-04-16 22:56 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).