From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Lee Jones <lee.jones@linaro.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Arnd Bergmann <arnd@kernel.org>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudius Heine <ch@denx.de>,
Linus Walleij <linus.walleij@linaro.org>,
linux-rtc@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] [v2] rtc: bd70528: fix BD71815 watchdog dependency
Date: Tue, 25 May 2021 00:25:39 +0200 [thread overview]
Message-ID: <162189513064.208942.8503261764736710854.b4-ty@bootlin.com> (raw)
In-Reply-To: <20210422151545.2403356-1-arnd@kernel.org>
On Thu, 22 Apr 2021 17:15:21 +0200, Arnd Bergmann wrote:
> The added Kconfig dependency is slightly incorrect, which can
> lead to a link failure when the watchdog is a loadable module:
>
> arm-linux-gnueabi-ld: drivers/rtc/rtc-bd70528.o: in function `bd70528_set_rtc_based_timers':
> rtc-bd70528.c:(.text+0x6cc): undefined reference to `bd70528_wdt_set'
> arm-linux-gnueabi-ld: drivers/rtc/rtc-bd70528.o: in function `bd70528_set_time':
> rtc-bd70528.c:(.text+0xaa0): undefined reference to `bd70528_wdt_lock'
> arm-linux-gnueabi-ld: rtc-bd70528.c:(.text+0xab8): undefined reference to `bd70528_wdt_unlock'
> arm-linux-gnueabi-ld: drivers/rtc/rtc-bd70528.o: in function `bd70528_alm_enable':
> rtc-bd70528.c:(.text+0xfc0): undefined reference to `bd70528_wdt_lock'
> arm-linux-gnueabi-ld: rtc-bd70528.c:(.text+0x1030): undefined reference to `bd70528_wdt_unlock'
>
> [...]
Applied, thanks!
[1/1] rtc: bd70528: fix BD71815 watchdog dependency
commit: b0ddc5b170058a9ed3c9f031501d735a4eb8ee89
Best regards,
--
Alexandre Belloni <alexandre.belloni@bootlin.com>
prev parent reply other threads:[~2021-05-24 22:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 15:15 [PATCH] [v2] rtc: bd70528: fix BD71815 watchdog dependency Arnd Bergmann
2021-04-22 16:08 ` Guenter Roeck
2021-04-23 3:58 ` Matti Vaittinen
2021-04-28 1:39 ` Randy Dunlap
2021-05-24 22:25 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162189513064.208942.8503261764736710854.b4-ty@bootlin.com \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=ch@denx.de \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matti.vaittinen@fi.rohmeurope.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).