linux-rtc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] rtc: ds3232: avoid unused-const-variable warning
@ 2023-11-18  9:22 Akinobu Mita
  2024-01-08  0:31 ` Alexandre Belloni
  0 siblings, 1 reply; 2+ messages in thread
From: Akinobu Mita @ 2023-11-18  9:22 UTC (permalink / raw)
  To: linux-rtc; +Cc: akinobu.mita, a.zummo, alexandre.belloni, kernel test robot

Fix the following warning when CONFIG_I2C is not set but CONFIG_SPI_MASTER
is set.

warning: 'ds3232_pm_ops' defined but not used [-Wunused-const-variable=]

'ds3232_pm_ops' is only used by rtc-ds3232 i2c driver, so move the device
PM callbacks inside #if IS_ENABLED(CONFIG_I2C).

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202311172325.33tTniaJ-lkp@intel.com/
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
---
 drivers/rtc/rtc-ds3232.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/rtc/rtc-ds3232.c b/drivers/rtc/rtc-ds3232.c
index 89d7b085f721..1485a6ae51e6 100644
--- a/drivers/rtc/rtc-ds3232.c
+++ b/drivers/rtc/rtc-ds3232.c
@@ -536,6 +536,8 @@ static int ds3232_probe(struct device *dev, struct regmap *regmap, int irq,
 	return 0;
 }
 
+#if IS_ENABLED(CONFIG_I2C)
+
 #ifdef CONFIG_PM_SLEEP
 static int ds3232_suspend(struct device *dev)
 {
@@ -564,8 +566,6 @@ static const struct dev_pm_ops ds3232_pm_ops = {
 	SET_SYSTEM_SLEEP_PM_OPS(ds3232_suspend, ds3232_resume)
 };
 
-#if IS_ENABLED(CONFIG_I2C)
-
 static int ds3232_i2c_probe(struct i2c_client *client)
 {
 	struct regmap *regmap;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] rtc: ds3232: avoid unused-const-variable warning
  2023-11-18  9:22 [PATCH] rtc: ds3232: avoid unused-const-variable warning Akinobu Mita
@ 2024-01-08  0:31 ` Alexandre Belloni
  0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2024-01-08  0:31 UTC (permalink / raw)
  To: linux-rtc, Akinobu Mita; +Cc: a.zummo, kernel test robot


On Sat, 18 Nov 2023 18:22:00 +0900, Akinobu Mita wrote:
> Fix the following warning when CONFIG_I2C is not set but CONFIG_SPI_MASTER
> is set.
> 
> warning: 'ds3232_pm_ops' defined but not used [-Wunused-const-variable=]
> 
> 'ds3232_pm_ops' is only used by rtc-ds3232 i2c driver, so move the device
> PM callbacks inside #if IS_ENABLED(CONFIG_I2C).
> 
> [...]

Applied, thanks!

[1/1] rtc: ds3232: avoid unused-const-variable warning
      commit: 3628d999e31e2e31b51f78b0f68e91275854c179

Best regards,

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-01-08  0:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-18  9:22 [PATCH] rtc: ds3232: avoid unused-const-variable warning Akinobu Mita
2024-01-08  0:31 ` Alexandre Belloni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).