From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Tilki, Ibrahim" <Ibrahim.Tilki@analog.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: "a.zummo@towertech.it" <a.zummo@towertech.it>,
"jdelvare@suse.com" <jdelvare@suse.com>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Arslanbenzer, Zeynep" <Zeynep.Arslanbenzer@analog.com>
Subject: Re: [PATCH v5 2/2] dt-bindings: rtc: add max313xx RTCs
Date: Tue, 4 Apr 2023 12:08:18 +0200 [thread overview]
Message-ID: <1efdb870-cac2-f6ed-72b5-d0550dbb5257@linaro.org> (raw)
In-Reply-To: <CY4PR03MB2488DFC99C23ADE16FF40E2F96939@CY4PR03MB2488.namprd03.prod.outlook.com>
On 04/04/2023 11:26, Tilki, Ibrahim wrote:
>>>> + aux-voltage-chargeable:
>>>> + enum: [0, 1, 2]
>>>> + description: |
>>>> + Enables trickle charger.
>>>> + 0: Charger is disabled (default)
>>>> + 1: Charger is enabled
>>>> + 2: Charger is enabled with a diode
>>>
>>> 2 is not an allowed value. I asked to drop this property. It is coming
>>> from rtc.yaml. I also do not understand "with a diode". So otherwise it
>>> is charging with, I don't know, FET?
>>
>> No, what is not explained here (and maybe not unsterstood by the
>> submitter) is that the RTC has an extra diode so, charging will always
>> enable a diode, select a resistor and then have or not an extra diode.
>> Figure2 of the MAX31329 datasheet is great.
>>
>
> That is exactly why I had "adi,trickle-diode-enable" property in previous patch.
> So if I can't have "adi,trickle-diode-enable" and can't add an additional value
> to "aux-voltage-chargeable", I am not sure how to add support for the extra
> diode at this point.
Ask the person who asked you to remove adi,trickle-diode-enable...
Anyway even if you decided to go with such advise, the solution is not
to create binding which fails.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-04-04 10:08 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 15:43 [PATCH v5 0/2] drivers: rtc: add max313xx series rtc driver Ibrahim Tilki
2023-04-03 15:43 ` [PATCH v5 1/2] " Ibrahim Tilki
2023-04-04 13:10 ` Krzysztof Kozlowski
2023-04-23 22:52 ` Chris Packham
2023-04-23 23:27 ` Chris Packham
2023-04-03 15:43 ` [PATCH v5 2/2] dt-bindings: rtc: add max313xx RTCs Ibrahim Tilki
2023-04-04 6:17 ` Krzysztof Kozlowski
2023-04-04 7:10 ` Alexandre Belloni
2023-04-04 7:21 ` Krzysztof Kozlowski
2023-04-04 7:44 ` Alexandre Belloni
2023-04-04 8:14 ` Krzysztof Kozlowski
2023-04-04 9:32 ` Tilki, Ibrahim
2023-04-04 9:56 ` Alexandre Belloni
2023-04-04 10:06 ` Krzysztof Kozlowski
2023-04-04 12:18 ` Alexandre Belloni
2023-04-04 9:26 ` Tilki, Ibrahim
2023-04-04 10:08 ` Krzysztof Kozlowski [this message]
2023-04-04 10:35 ` Tilki, Ibrahim
2023-04-04 12:26 ` Alexandre Belloni
2023-04-04 12:29 ` Alexandre Belloni
2023-04-04 13:02 ` Krzysztof Kozlowski
2023-04-04 14:50 ` Tilki, Ibrahim
2023-04-04 13:10 ` Krzysztof Kozlowski
2023-04-04 15:40 ` Tilki, Ibrahim
2023-04-05 6:16 ` Krzysztof Kozlowski
2024-01-26 2:22 ` [PATCH v5 0/2] drivers: rtc: add max313xx series rtc driver Chris Packham
2024-01-26 7:51 ` Nuno Sá
2024-01-29 3:28 ` Chris Packham
2024-01-29 7:55 ` Nuno Sá
2024-02-02 0:28 ` Chris Packham
2024-02-02 6:56 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1efdb870-cac2-f6ed-72b5-d0550dbb5257@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Ibrahim.Tilki@analog.com \
--cc=Zeynep.Arslanbenzer@analog.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).