On Tue, Jul 31, 2018 at 03:57:27PM +0800, Tony Xie wrote: > + default: > + pr_warn("%s ramp_delay: %d not supported, setting 10000\n", > + rdev->desc->name, ramp_delay); > + } This looks mostly good but I notice that most of the prints in the driver are pr_ rather than dev_ ones - using dev_ is better as it allows people to see which device was affected.