From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Jia-Ju Bai <baijiaju1990@gmail.com>, johan@kernel.org, j-keerthy@ti.com
Cc: a.zummo@towertech.it, linux-rtc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: rtc-omap: Replace mdelay() with msleep() in omap_rtc_power_off()
Date: Mon, 27 Aug 2018 22:55:17 +0200 [thread overview]
Message-ID: <20180827205517.GD24549@piout.net> (raw)
In-Reply-To: <20180730135314.9336-1-baijiaju1990@gmail.com>
Hi,
On 30/07/2018 21:53:14+0800, Jia-Ju Bai wrote:
> omap_rtc_power_off() is never called in atomic context.
> It calls mdelay() to busily wait, which is not necessary.
> mdelay() can be replaced with msleep().
>
> This is found by a static analysis tool named DCNS written by myself.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
> ---
> drivers/rtc/rtc-omap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
> index 39086398833e..ef3d09525d0f 100644
> --- a/drivers/rtc/rtc-omap.c
> +++ b/drivers/rtc/rtc-omap.c
> @@ -476,7 +476,7 @@ static void omap_rtc_power_off(void)
> * power off the system. Add a 500 ms margin for external latencies
> * (e.g. debounce circuits).
> */
> - mdelay(2500);
> + msleep(2500);
I'm not sure about that one because this is a poweroff function so it
doesn't really make sense to sleep versus busy waiting (all the drivers
in power/reset use mdelay())
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-08-28 0:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 13:53 [PATCH] rtc: rtc-omap: Replace mdelay() with msleep() in omap_rtc_power_off() Jia-Ju Bai
2018-08-27 20:55 ` Alexandre Belloni [this message]
2018-08-28 8:49 ` Johan Hovold
2018-08-28 9:06 ` Jia-Ju Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180827205517.GD24549@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=baijiaju1990@gmail.com \
--cc=j-keerthy@ti.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).