From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Craig McQueen <craig.mcqueen@innerrange.com>
Cc: "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>
Subject: Re: rtc-pcf85063 driver bug in pcf85063_stop_clock()
Date: Mon, 15 Oct 2018 14:39:58 +0200 [thread overview]
Message-ID: <20181015123958.GE17341@piout.net> (raw)
In-Reply-To: <7f8c164eb0fd47788ec6bbd34735f4a5@innerrange.com>
Hello,
On 11/10/2018 06:53:15+0000, Craig McQueen wrote:
> The function pcf85063_stop_clock() is intended to provide the value of the Control_1 register via the pointer ctrl1.
>
> However, it's really providing the return value of the last i2c_smbus_write_byte_data() call, i.e., zero. So the register value needs to be saved in a separate local variable other than ret. Or, the line *ctrl1 = ret; needs to be moved up to be above the last i2c_smbus_write_byte_data() call.
>
Isn't that fixed by http://patchwork.ozlabs.org/patch/944107/ ?
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-10-15 12:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 6:53 rtc-pcf85063 driver bug in pcf85063_stop_clock() Craig McQueen
2018-10-15 12:39 ` Alexandre Belloni [this message]
2018-11-19 22:56 ` Craig McQueen
2018-11-25 14:10 ` Alexandre Belloni
2018-11-26 0:21 ` Craig McQueen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181015123958.GE17341@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=craig.mcqueen@innerrange.com \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).