From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-rtc@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Joe Perches <joe@perches.com>, Mark Salyzyn <salyzyn@android.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kernel@vger.kernel.org,
Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Guan Xuetao <gxt@mprc.pku.edu.cn>
Subject: [PATCH v6 11/20] rtc: puv3: Switch to use %ptR
Date: Tue, 4 Dec 2018 23:23:21 +0200 [thread overview]
Message-ID: <20181204212330.69515-12-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20181204212330.69515-1-andriy.shevchenko@linux.intel.com>
Use %ptR instead of open coded variant to print content of
struct rtc_time in human readable format.
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/rtc/rtc-puv3.c | 18 ++++--------------
1 file changed, 4 insertions(+), 14 deletions(-)
diff --git a/drivers/rtc/rtc-puv3.c b/drivers/rtc/rtc-puv3.c
index 9e83be32ff43..f77ef282f013 100644
--- a/drivers/rtc/rtc-puv3.c
+++ b/drivers/rtc/rtc-puv3.c
@@ -90,9 +90,7 @@ static int puv3_rtc_gettime(struct device *dev, struct rtc_time *rtc_tm)
{
rtc_time_to_tm(readl(RTC_RCNR), rtc_tm);
- dev_dbg(dev, "read time %02x.%02x.%02x %02x/%02x/%02x\n",
- rtc_tm->tm_year, rtc_tm->tm_mon, rtc_tm->tm_mday,
- rtc_tm->tm_hour, rtc_tm->tm_min, rtc_tm->tm_sec);
+ dev_dbg(dev, "read time %ptRr\n", rtc_tm);
return 0;
}
@@ -101,9 +99,7 @@ static int puv3_rtc_settime(struct device *dev, struct rtc_time *tm)
{
unsigned long rtc_count = 0;
- dev_dbg(dev, "set time %02d.%02d.%02d %02d/%02d/%02d\n",
- tm->tm_year, tm->tm_mon, tm->tm_mday,
- tm->tm_hour, tm->tm_min, tm->tm_sec);
+ dev_dbg(dev, "set time %ptRr\n", tm);
rtc_tm_to_time(tm, &rtc_count);
writel(rtc_count, RTC_RCNR);
@@ -119,10 +115,7 @@ static int puv3_rtc_getalarm(struct device *dev, struct rtc_wkalrm *alrm)
alrm->enabled = readl(RTC_RTSR) & RTC_RTSR_ALE;
- dev_dbg(dev, "read alarm %02x %02x.%02x.%02x %02x/%02x/%02x\n",
- alrm->enabled,
- alm_tm->tm_year, alm_tm->tm_mon, alm_tm->tm_mday,
- alm_tm->tm_hour, alm_tm->tm_min, alm_tm->tm_sec);
+ dev_dbg(dev, "read alarm: %d, %ptRr\n", alrm->enabled, alm_tm);
return 0;
}
@@ -132,10 +125,7 @@ static int puv3_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm)
struct rtc_time *tm = &alrm->time;
unsigned long rtcalarm_count = 0;
- dev_dbg(dev, "puv3_rtc_setalarm: %d, %02x/%02x/%02x %02x.%02x.%02x\n",
- alrm->enabled,
- tm->tm_mday & 0xff, tm->tm_mon & 0xff, tm->tm_year & 0xff,
- tm->tm_hour & 0xff, tm->tm_min & 0xff, tm->tm_sec);
+ dev_dbg(dev, "set alarm: %d, %ptRr\n", alrm->enabled, tm);
rtc_tm_to_time(tm, &rtcalarm_count);
writel(rtcalarm_count, RTC_RTAR);
--
2.19.2
next prev parent reply other threads:[~2018-12-04 21:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 21:23 [PATCH v6 00/20] lib, rtc: Print rtc_time via %ptR[dt][r] Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 01/20] lib/vsprintf: Print time and date in human readable format via %pt Andy Shevchenko
2018-12-10 9:09 ` Andy Shevchenko
2018-12-10 14:51 ` Petr Mladek
2018-12-04 21:23 ` [PATCH v6 02/20] rtc: Switch to use %ptR Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 03/20] rtc: at91rm9200: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 04/20] rtc: at91sam9: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 05/20] rtc: m41t80: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 06/20] rtc: m48t59: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 07/20] rtc: mcp795: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 08/20] rtc: pcf50633: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 09/20] rtc: pic32: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 10/20] rtc: pm8xxx: " Andy Shevchenko
2018-12-04 21:23 ` Andy Shevchenko [this message]
2018-12-04 21:23 ` [PATCH v6 12/20] rtc: rk808: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 13/20] rtc: rx6110: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 14/20] rtc: rx8025: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 15/20] rtc: s3c: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 16/20] rtc: s5m: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 17/20] rtc: tegra: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 18/20] Input: hp_sdc_rtc - " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 19/20] m68k/mac: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 20/20] PM: " Andy Shevchenko
2018-12-11 11:53 ` Rafael J. Wysocki
2018-12-11 12:29 ` Andy Shevchenko
2018-12-11 10:53 ` [PATCH v6 00/20] lib, rtc: Print rtc_time via %ptR[dt][r] Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204212330.69515-12-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=gxt@mprc.pku.edu.cn \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=rasmus.villemoes@prevas.dk \
--cc=salyzyn@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).