From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: "Alessandro Zummo" <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org, "Jon Nettleton" <jon@solid-run.com>,
"Erik Čuk" <erik.cuk@domel.com>
Subject: Re: [PATCH] rtc: pcf8523: don't return invalid date when battery is low
Date: Tue, 11 Dec 2018 00:47:16 +0100 [thread overview]
Message-ID: <20181210234716.GM8952@piout.net> (raw)
In-Reply-To: <35660d21e523f535ac959dc9276f61104820f1bf.1544022009.git.baruch@tkos.co.il>
On 05/12/2018 17:00:09+0200, Baruch Siach wrote:
> The RTC_VL_READ ioctl reports the low battery condition. Still,
> pcf8523_rtc_read_time() happily returns invalid dates in this case.
> Check the battery health on pcf8523_rtc_read_time() to avoid that.
>
> Reported-by: Erik Čuk <erik.cuk@domel.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> drivers/rtc/rtc-pcf8523.c | 32 ++++++++++++++++++++++++--------
> 1 file changed, 24 insertions(+), 8 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-12-10 23:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 15:00 [PATCH] rtc: pcf8523: don't return invalid date when battery is low Baruch Siach
2018-12-10 23:47 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210234716.GM8952@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=baruch@tkos.co.il \
--cc=erik.cuk@domel.com \
--cc=jon@solid-run.com \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).