From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Jan Kotas <jank@cadence.com>
Cc: Rob Herring <robh@kernel.org>,
"a.zummo@towertech.it" <a.zummo@towertech.it>,
Mark Rutland <mark.rutland@arm.com>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: rtc: Add bindings for Cadence RTC
Date: Thu, 17 Jan 2019 13:08:42 +0100 [thread overview]
Message-ID: <20190117120842.GB26715@piout.net> (raw)
In-Reply-To: <46BA7224-B229-4594-B039-8801A806657E@global.cadence.com>
On 17/01/2019 10:46:50+0000, Jan Kotas wrote:
>
> > On 16 Jan 2019, at 22:08, Rob Herring <robh@kernel.org> wrote:
> >
> >
> > On Fri, Jan 11, 2019 at 03:14:00PM +0000, Jan Kotas wrote:
> >> This patch adds a DT binding documentation for
> >> Cadence RTC controller.
> >> +Required properties:
> >> +- compatible: Should be "cdns,rtc-r109v3"
> >> +- reg: Specifies base physical address and size of the register area.
> >> +- interrupts: A single interrupt specifier.
> >> +- clocks: Must contain two entries:
> >> + - pclk: APB registers clock
> >> + - ref_clk: reference 1Hz of 100Hz clock, depending on IP configuration
> >
> > 1Hz OR 100Hz?
>
> Hi,
>
> The IP has a configuration parameter at build time,
> which selects the reference clock frequency.
>
> It cannot be changed later, and there’s no register which
> tells the software which option was selected.
>
> In this version of the patch, both values are accepted.
> If it makes sense I can add a bool property, like
> refclock-100hz, which can be used to check the clock frequency.
>
I guess what rob suggested was s/of/or/
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-01-17 12:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 15:13 [PATCH v2 0/2] rtc: Add a driver for Cadence RTC Jan Kotas
2019-01-11 15:14 ` [PATCH v2 1/2] dt-bindings: rtc: Add bindings " Jan Kotas
2019-01-16 21:08 ` Rob Herring
2019-01-17 10:46 ` Jan Kotas
2019-01-17 12:08 ` Alexandre Belloni [this message]
2019-01-11 15:14 ` [PATCH v2 2/2] rtc: Add Cadence RTC driver Jan Kotas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190117120842.GB26715@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=devicetree@vger.kernel.org \
--cc=jank@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).