From: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Lee Jones <lee.jones@linaro.org>,
Matti Vaittinen <mazziesaccount@gmail.com>,
heikki.haikola@fi.rohmeurope.com,
mikko.mutanen@fi.rohmeurope.com, robh+dt@kernel.org,
mark.rutland@arm.com, broonie@kernel.org,
gregkh@linuxfoundation.org, rafael@kernel.org,
mturquette@baylibre.com, sboyd@kernel.org,
linus.walleij@linaro.org, bgolaszewski@baylibre.com,
sre@kernel.org, lgirdwood@gmail.com, a.zummo@towertech.it,
alexandre.belloni@bootlin.com, wim@linux-watchdog.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v8 4/8] devicetree: bindings: Document first ROHM BD70528 bindings
Date: Thu, 7 Feb 2019 18:33:42 +0200 [thread overview]
Message-ID: <20190207163342.GC1920@localhost.localdomain> (raw)
In-Reply-To: <20190207154229.GA19277@roeck-us.net>
On Thu, Feb 07, 2019 at 07:42:29AM -0800, Guenter Roeck wrote:
> On Thu, Feb 07, 2019 at 05:36:00PM +0200, Matti Vaittinen wrote:
> > Hello Lee,
> >
> > Thanks for the reviews!
> >
> > On Thu, Feb 07, 2019 at 02:04:18PM +0000, Lee Jones wrote:
> > > On Thu, 07 Feb 2019, Matti Vaittinen wrote:
> > >
> > > > Document bindings for regulators (3 bucks, 3 LDOs and 2 LED
> > > > drivers) and 4 GPIO pins which can be configured for I/O or
> > > > as interrupt sources withe configurable trigger levels.
> > > >
> > > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > > > Reviewed-by: Rob Herring <robh@kernel.org>
> > > > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> > > > ---
> > > > .../devicetree/bindings/mfd/rohm,bd70528-pmic.txt | 102 +++++++++++++++++++++
> > > > 1 file changed, 102 insertions(+)
> > > > create mode 100644 Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt b/Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt
> > > > new file mode 100644
> > > > index 000000000000..f80be7e40184
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt
> > > > @@ -0,0 +1,102 @@
> > > > +* ROHM BD70528 Power Management Integrated Circuit bindings
> > > > +
> > > > +BD70528MWV is an ultra-low Iq general purpose single-chip power management IC
> > >
> > > What's an Iq?
> >
> > http://www.ti.com/lit/an/slyt412/slyt412.pdf
> > Iq is an abbreviation of quiescet current. Do you think it's worth
> > writing the whole words instead of an abbreviation?
> >
> https://acronyms.thefreedictionary.com/IQ lists 23 definitions.
> This one is not listed. Yes, I think it would be beneficial to use
> the whole word.
Allright. I'll change that too =)
Br,
Matti Vaittinen
--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND
~~~ "I don't think so," said Rene Descartes. Just then, he vanished ~~~
next prev parent reply other threads:[~2019-02-07 16:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 7:27 [PATCH v8 0/8] support ROHM BD70528 PMIC Matti Vaittinen
2019-02-07 7:34 ` [PATCH v8 1/8] mfd: regulator: clk: split rohm-bd718x7.h Matti Vaittinen
2019-02-07 11:41 ` Lee Jones
2019-02-07 7:35 ` [PATCH v8 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core Matti Vaittinen
2019-02-07 14:00 ` Lee Jones
2019-02-07 16:28 ` Matti Vaittinen
2019-02-08 10:57 ` Lee Jones
2019-02-08 12:41 ` Matti Vaittinen
2019-02-12 9:17 ` Lee Jones
2019-02-12 9:37 ` Matti Vaittinen
2019-02-08 7:30 ` Matti Vaittinen
2019-02-07 7:36 ` [PATCH v8 3/8] clk: bd718x7: Support ROHM BD70528 clk block Matti Vaittinen
2019-02-07 7:37 ` [PATCH v8 4/8] devicetree: bindings: Document first ROHM BD70528 bindings Matti Vaittinen
2019-02-07 14:04 ` Lee Jones
2019-02-07 15:36 ` Matti Vaittinen
2019-02-07 15:42 ` Guenter Roeck
2019-02-07 16:33 ` Matti Vaittinen [this message]
2019-02-07 7:38 ` [PATCH v8 5/8] gpio: Initial support for ROHM bd70528 GPIO block Matti Vaittinen
2019-02-07 7:39 ` [PATCH v8 6/8] rtc: bd70528: Initial support for ROHM bd70528 RTC Matti Vaittinen
2019-02-07 7:40 ` [PATCH v8 7/8] power: supply: Initial support for ROHM BD70528 PMIC charger block Matti Vaittinen
2019-02-07 7:42 ` [PATCH v8 8/8] watchdog: bd70528: Initial support for ROHM BD70528 watchdog block Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207163342.GC1920@localhost.localdomain \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.haikola@fi.rohmeurope.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=mazziesaccount@gmail.com \
--cc=mikko.mutanen@fi.rohmeurope.com \
--cc=mturquette@baylibre.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sre@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).