From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: linux-amlogic@lists.infradead.org, linux-rtc@vger.kernel.org,
alexandre.belloni@bootlin.com, a.zummo@towertech.it
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, ben.dooks@codethink.co.uk,
ccaione@baylibre.com,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: [PATCH v7 0/2] Amlogic Meson6/8/8b/8m2 SoC RTC driver
Date: Sat, 9 Feb 2019 01:18:11 +0100 [thread overview]
Message-ID: <20190209001813.6792-1-martin.blumenstingl@googlemail.com> (raw)
This series adds support for the RTC on the 32-bit Amlogic Meson SoCs.
The series does not have any build dependencies, but does require
device-tree entries for the relevant boards.
The series is tested by myself on the Meson8b EC-100 board. Earlier
versions of this series were tested on an Odroid-C1 board with a
battery pack attached by Ben Dooks and Kevin Hilman.
I will send the DT changes in a second series so that they can be
merged once the dependencies have been satisfied.
Changes since v6 at [2]:
- added NVMEM_TYPE_BATTERY_BACKED (thanks to Alexandre Belloni for the
hint)
- fixed dt-bindings description: #address-cells was duplicated but
#size-cells was missing. While here also add these to the example.
Spotted by Alexandre Belloni - thanks!
Changes since v5 at [1]:
- get rid of a dependency on the SZ_16 macro (fixes a kbuild test robot
compile error)
- rebased on top of v5.0-rc1
- I kept the copyrights / author as in v4 because Ben didn't ask me to
do it yet (please speak up if I should change it)
Changes since v4 at [0]:
- resurrected Ben's patches after 2 years: first I made it apply
onto linux-next again
- I decided to update the author of the patch to my own name since I
made a lot of changes compared to Ben's implementation (list of
changes below, the diff-stat was: 223 insertions, 163 deletions)
- make the dt-bindings file name (rtc-meson.txt) match the driver name
- add a Meson8m2 compatible
- add the clocks and vdd-supply properties to the match the actual IP
block implementation
- make the resets and interrupts properties mandatory to match the
actual IP block implementation
- removed the status property from the dt-bindings example
- fix MODULE_LICENSE to match the actual license (GPL v2)
- switch to SPDX-License-Identifier
- sort the Kconfig option alphabetically
- use BIT() and GENMASK() macros consistenly
- replace #define RTC_REG(x) with actual #defines which match the names
from the public S805 datasheet
- adjust existing #defines to align with the public S805 datasheet
- add support for the 4x32bit NVMEM (regmem) data
- implement regmap_bus to access the serial registers. this allows
getting rid of the custom locking code and makes the NVMEM
implementation much easier.
- use regmap also for accessing the peripheral registers to make the
code shorter
- add support for the vdd-supply regulator
- switch from devm_rtc_device_register to devm_rtc_allocate_device and
rtc_register_device
- set range_max to U32_MAX
- use rtc_time64_to_tm and rtc_tm_to_time64
- simplify timeout handling and use shorter timeouts (the driver from
the 3.10 BSP kernel uses udelay resolution (100us after the reset, 5us
for the "comm delay") as well as busy-looping from 0..40000 to wait
for "s_ready"
- removed debug messages which are only printing register values (as
these can now be seen in
<debugfs>/regmap/c8100740.rtc-peripheral-registers/registers)
[0] https://www.spinics.net/lists/devicetree/msg135413.html
[1] https://patchwork.ozlabs.org/cover/1006597/
[2] https://patchwork.ozlabs.org/cover/1027951/
Martin Blumenstingl (2):
dt-bindings: rtc: add device-tree bindings for the Amlogic Meson RTC
rtc: support for the Amlogic Meson RTC
.../devicetree/bindings/rtc/rtc-meson.txt | 35 ++
drivers/rtc/Kconfig | 11 +
drivers/rtc/Makefile | 1 +
drivers/rtc/rtc-meson.c | 410 ++++++++++++++++++
4 files changed, 457 insertions(+)
create mode 100644 Documentation/devicetree/bindings/rtc/rtc-meson.txt
create mode 100644 drivers/rtc/rtc-meson.c
--
2.20.1
next reply other threads:[~2019-02-09 0:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-09 0:18 Martin Blumenstingl [this message]
2019-02-09 0:18 ` [PATCH v7 1/2] dt-bindings: rtc: add device-tree bindings for the Amlogic Meson RTC Martin Blumenstingl
2019-02-10 21:21 ` Alexandre Belloni
2019-02-09 0:18 ` [PATCH v7 2/2] rtc: support " Martin Blumenstingl
2019-02-10 21:21 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190209001813.6792-1-martin.blumenstingl@googlemail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=ben.dooks@codethink.co.uk \
--cc=ccaione@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).