Linux-RTC Archive on lore.kernel.org
 help / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Trent Piepho <tpiepho@impinj.com>
Cc: "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
	Alessandro Zummo <a.zummo@towertech.it>
Subject: Re: [PATCH 2/3] rtc: isl1208: Support more chip variations
Date: Sun, 10 Feb 2019 22:12:39 +0100
Message-ID: <20190210211239.GH23062@piout.net> (raw)
In-Reply-To: <20190201194147.25885-2-tpiepho@impinj.com>

Hi,

Very few comments below:

On 01/02/2019 19:42:12+0000, Trent Piepho wrote:
> Add more support in the driver for dealing with differences in is1208
> compatible chips.  Put the 1208, 1209, 1218, and 1219 in the list and
> encode information about nvram size, tamper, and timestamp features.
> 
> This adds support for the isl1209, which has a tamper detect but no
> timestamp feature.
> 
> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Signed-off-by: Trent Piepho <tpiepho@impinj.com>
> ---
>  drivers/rtc/rtc-isl1208.c | 78 ++++++++++++++++++++++++++++++++++-------------
>  1 file changed, 56 insertions(+), 22 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c
> index d8e0670e12fc..77912ee58011 100644
> --- a/drivers/rtc/rtc-isl1208.c
> +++ b/drivers/rtc/rtc-isl1208.c
> @@ -73,15 +73,49 @@
>  static struct i2c_driver isl1208_driver;
>  
>  /* ISL1208 various variants */
> -enum {
> +enum isl1208_id {
>  	TYPE_ISL1208 = 0,
>  	TYPE_ISL1218,
>  	TYPE_ISL1219,
> +	TYPE_ISL1209,

I would keep that list ordered.

> +	ISL_LAST_ID
>  };
>  
> +/* Chip capabilities table */
> +static const struct isl1208_config {
> +	const char	name[8];
> +	unsigned int	nvmem_length;
> +	unsigned	has_tamper:1;
> +	unsigned	has_timestamp:1;
> +} isl1208_configs[] = {
> +	[TYPE_ISL1208] = { "isl1208", 2, false, false },
> +	[TYPE_ISL1209] = { "isl1209", 2, true,  false },
> +	[TYPE_ISL1218] = { "isl1218", 8, false, false },
> +	[TYPE_ISL1219] = { "isl1219", 2, true,  true },
> +};
> +
> +static const struct i2c_device_id isl1208_id[] = {
> +	{ "isl1208", TYPE_ISL1208 },
> +	{ "isl1209", TYPE_ISL1209 },
> +	{ "isl1218", TYPE_ISL1218 },
> +	{ "isl1219", TYPE_ISL1219 },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(i2c, isl1208_id);
> +
> +static const struct of_device_id isl1208_of_match[] = {
> +	{ .compatible = "isil,isl1208", .data = &isl1208_configs[TYPE_ISL1208] },
> +	{ .compatible = "isil,isl1209", .data = &isl1208_configs[TYPE_ISL1209] },

This compatible needs to be documented.

> +	{ .compatible = "isil,isl1218", .data = &isl1208_configs[TYPE_ISL1218] },
> +	{ .compatible = "isil,isl1219", .data = &isl1208_configs[TYPE_ISL1219] },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, isl1208_of_match);
> +
>  /* Device state */
>  struct isl1208_state {
>  	struct rtc_device *rtc;
> +	const struct isl1208_config *config;
>  };
>  
>  /* block read */
> @@ -602,11 +636,12 @@ isl1208_rtc_interrupt(int irq, void *data)
>  			return err;
>  	}
>  
> -	if (sr & ISL1208_REG_SR_EVT) {
> -		sysfs_notify(&isl1208->rtc->dev.kobj, NULL,
> -			     dev_attr_timestamp0.attr.name);
> +	if (isl1208->config->has_tamper && (sr & ISL1208_REG_SR_EVT)) {
>  		dev_warn(&client->dev, "event detected");
>  		handled = 1;
> +		if (isl1208->config->has_timestamp)
> +			sysfs_notify(&isl1208->rtc->dev.kobj, NULL,
> +				     dev_attr_timestamp0.attr.name);
>  	}
>  
>  	return handled ? IRQ_HANDLED : IRQ_NONE;
> @@ -743,6 +778,19 @@ isl1208_probe(struct i2c_client *client, const struct i2c_device_id *id)
>  		return -ENOMEM;
>  	i2c_set_clientdata(client, isl1208);
>  
> +	/* Determine which chip we have */
> +	if (client->dev.of_node) {
> +		const struct of_device_id *match =
> +			of_match_node(isl1208_of_match, client->dev.of_node);
> +		if (!match)

This will never happen, else the driver would not be probed.

> +			return -EINVAL;
> +		isl1208->config = match->data;

Maybe you should use of_device_get_match_data anyway.

> +	} else {
> +		if (id->driver_data >= ISL_LAST_ID)
> +			return -EINVAL;

This should be -ENODEV.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-01 19:42 [PATCH 1/3] rtc: isl1208: Introduce driver state struct Trent Piepho
2019-02-01 19:42 ` [PATCH 2/3] rtc: isl1208: Support more chip variations Trent Piepho
2019-02-10 21:12   ` Alexandre Belloni [this message]
2019-02-12  1:30     ` Trent Piepho
2019-02-01 19:42 ` [PATCH 3/3] rtc: isl1208: Add new style nvmem support to driver Trent Piepho

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190210211239.GH23062@piout.net \
    --to=alexandre.belloni@bootlin.com \
    --cc=a.zummo@towertech.it \
    --cc=linux-rtc@vger.kernel.org \
    --cc=tpiepho@impinj.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-RTC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rtc/0 linux-rtc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rtc linux-rtc/ https://lore.kernel.org/linux-rtc \
		linux-rtc@vger.kernel.org linux-rtc@archiver.kernel.org
	public-inbox-index linux-rtc


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rtc


AGPL code for this site: git clone https://public-inbox.org/ public-inbox