* [PATCH] rtc: meson: remove useless rtc_nvmem_unregister call
@ 2019-02-11 10:33 Alexandre Belloni
2019-02-17 14:02 ` Martin Blumenstingl
0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Belloni @ 2019-02-11 10:33 UTC (permalink / raw)
To: linux-rtc; +Cc: Martin Blumenstingl, linux-kernel, Alexandre Belloni
rtc_nvmem_unregister() is called on rtc_device release so it is not
necessary to call it from the driver.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
drivers/rtc/rtc-meson.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/rtc/rtc-meson.c b/drivers/rtc/rtc-meson.c
index 6fc4b09e7ebd..e08b981dfc21 100644
--- a/drivers/rtc/rtc-meson.c
+++ b/drivers/rtc/rtc-meson.c
@@ -373,13 +373,10 @@ static int meson_rtc_probe(struct platform_device *pdev)
ret = rtc_register_device(rtc->rtc);
if (ret)
- goto out_unregister_nvmem;
+ goto out_disable_vdd;
return 0;
-out_unregister_nvmem:
- rtc_nvmem_unregister(rtc->rtc);
-
out_disable_vdd:
regulator_disable(rtc->vdd);
return ret;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: meson: remove useless rtc_nvmem_unregister call
2019-02-11 10:33 [PATCH] rtc: meson: remove useless rtc_nvmem_unregister call Alexandre Belloni
@ 2019-02-17 14:02 ` Martin Blumenstingl
0 siblings, 0 replies; 2+ messages in thread
From: Martin Blumenstingl @ 2019-02-17 14:02 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: linux-rtc, linux-kernel
Hi Alexandre,
On Mon, Feb 11, 2019 at 11:33 AM Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
>
> rtc_nvmem_unregister() is called on rtc_device release so it is not
> necessary to call it from the driver.
thank you for taking care of the linker-error!
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Regards
Martin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-17 14:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-11 10:33 [PATCH] rtc: meson: remove useless rtc_nvmem_unregister call Alexandre Belloni
2019-02-17 14:02 ` Martin Blumenstingl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).