From: Pavel Machek <pavel@ucw.cz>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Guenter Roeck <groeck@google.com>,
Dmitry Torokhov <dtor@google.com>,
Nick Crews <ncrews@chromium.org>,
Benson Leung <bleung@chromium.org>,
linux-leds@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Duncan Laurie <dlaurie@chromium.org>,
Simon Glass <sjg@google.com>
Subject: Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name
Date: Sat, 6 Apr 2019 11:53:46 +0200 [thread overview]
Message-ID: <20190406095346.GB7546@amd> (raw)
In-Reply-To: <469dfb68-a7ab-668d-15cb-9e021c0d3f0c@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1755 bytes --]
Hi!
> The patch set introduces also a set of predefined LED_FUNCTION
> names to be used in DT bindings. This along with the removal
> of devicename section from LED naming pattern will help to keep
> LED sysfs interface more uniform and not varying depending on
> underlaying hardware driving the LEDs.
>
> Regarding the problem discussed in this thread - I would not necessarily
> go for "platform" in place of devicename LED name section in the
> cros_kbd_led_backlight driver. If we change it (should we at all - it is
> already in 5.0 AFAICS?), then I would opt for dropping the "chromeos:"
> part. It believe it will be possible to retrieve this name with
> get_led_device_info.sh script. It would be good exercise to check
> it out.
I am not sure about existing driver. Important thing for me is that
new drivers use consistent naming.
> In cases like above:
>
> keyboardist::kbd_backlight
> tclnumpad::kbd_backlight
>
> we could do with the following:
>
> :kbd-backlight
> :numpad-backlight
>
> I used hyphens instead of underscores since we will have this convention
> in the LED_FUNCTION names, which is more common for Device Tree, and
> some of existing LED triggers.
Existing userspace already searches for *:kbd_backlight", AFAICT, so
we probably want to keep the "_".
I don't care much if we use "platform:" or no prefix at all for
backlight of internal keyboard, as long as it is consistent across all
devices.
We certainly want to use some prefix (probably inputX:) for backlight
on USB keyboards.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-04-06 9:53 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 17:10 [PATCH v5 1/3] platform/chrome: wilco_ec: Standardize mailbox interface Nick Crews
2019-04-04 17:10 ` [PATCH v5 2/3] platform/chrome: Add Wilco EC keyboard backlight LEDs support Nick Crews
2019-04-04 19:52 ` Pavel Machek
2019-04-05 20:15 ` Guenter Roeck
2019-04-06 8:41 ` Pavel Machek
2019-04-07 21:46 ` Dmitry Torokhov
2019-04-07 22:18 ` Pavel Machek
2019-04-07 22:26 ` Dmitry Torokhov
2019-04-08 9:41 ` Keyboard backlight LED naming was " Pavel Machek
2019-04-08 13:31 ` Guenter Roeck
2019-04-04 17:10 ` [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name Nick Crews
2019-04-04 17:36 ` Guenter Roeck
2019-04-04 17:43 ` Dmitry Torokhov
2019-04-04 18:41 ` Nick Crews
2019-04-04 18:55 ` Dmitry Torokhov
2019-04-04 18:59 ` Pavel Machek
2019-04-04 19:05 ` Dmitry Torokhov
2019-04-04 19:19 ` Pavel Machek
2019-04-04 19:59 ` Dmitry Torokhov
2019-04-04 20:06 ` Pavel Machek
2019-04-04 20:13 ` Dmitry Torokhov
2019-04-04 20:20 ` Pavel Machek
2019-04-04 20:26 ` Dmitry Torokhov
2019-04-04 20:42 ` Pavel Machek
2019-04-04 21:48 ` Dmitry Torokhov
2019-04-04 22:05 ` Pavel Machek
2019-04-04 22:42 ` Guenter Roeck
2019-04-05 8:42 ` Enric Balletbo i Serra
2019-04-05 20:00 ` Jacek Anaszewski
2019-04-06 9:53 ` Pavel Machek [this message]
2019-04-06 14:15 ` Jacek Anaszewski
2019-04-06 22:17 ` Pavel Machek
2019-04-07 22:01 ` Dmitry Torokhov
2019-04-08 20:01 ` Jacek Anaszewski
2019-04-04 18:56 ` Pavel Machek
2019-04-08 23:58 ` Nick Crews
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190406095346.GB7546@amd \
--to=pavel@ucw.cz \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=bleung@chromium.org \
--cc=dlaurie@chromium.org \
--cc=dtor@google.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@google.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=ncrews@chromium.org \
--cc=sjg@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).