From: Chen-Yu Tsai <wens@kernel.org>
To: Maxime Ripard <maxime.ripard@bootlin.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Chen-Yu Tsai <wens@kernel.org>,
Vincent Donnefort <vdonnefort@gmail.com>,
linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] rtc: pcf8563: Fix unhandled interrupt storm
Date: Tue, 4 Jun 2019 12:23:34 +0800 [thread overview]
Message-ID: <20190604042337.26129-1-wens@kernel.org> (raw)
From: Chen-Yu Tsai <wens@csie.org>
Hi everyone,
While bringing up my Pine H64, I encountered an interrupt storm from the
pcf8563 RTC. The RTC chip's interrupt line is shared with the PMIC, and
was not properly added to the device tree. Also, the driver was using an
trigger method incompatible with the PMIC, preventing the interrupt line
from being shared. Last, the driver only clears and masks the alarm
interrupt, while leaving the timer interrupt untouched. This is a
problem if previous systems left the timer interrupt enabled, and there
was an interrupt pending.
This patch set fixes all three issues, one per patch.
Please have a look.
Chen-Yu Tsai (3):
rtc: pcf8563: Fix interrupt trigger method
rtc: pcf8563: Clear event flags and disable interrupts before
requesting irq
arm64: dts: allwinner: h6: Pine H64: Add interrupt line for RTC
.../arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts | 2 ++
drivers/rtc/rtc-pcf8563.c | 13 ++++++-------
2 files changed, 8 insertions(+), 7 deletions(-)
--
2.20.1
next reply other threads:[~2019-06-04 4:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 4:23 Chen-Yu Tsai [this message]
2019-06-04 4:23 ` [PATCH 1/3] rtc: pcf8563: Fix interrupt trigger method Chen-Yu Tsai
2019-06-20 18:36 ` Alexandre Belloni
2019-06-04 4:23 ` [PATCH 2/3] rtc: pcf8563: Clear event flags and disable interrupts before requesting irq Chen-Yu Tsai
2019-06-20 18:37 ` Alexandre Belloni
2019-06-04 4:23 ` [PATCH 3/3] arm64: dts: allwinner: h6: Pine H64: Add interrupt line for RTC Chen-Yu Tsai
2019-06-20 16:22 ` [PATCH 0/3] rtc: pcf8563: Fix unhandled interrupt storm Alexandre Belloni
2019-06-24 10:34 ` Chen-Yu Tsai
2019-06-24 10:42 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190604042337.26129-1-wens@kernel.org \
--to=wens@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=vdonnefort@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).