From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E3CCC0650F for ; Mon, 5 Aug 2019 07:23:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DED9120B1F for ; Mon, 5 Aug 2019 07:23:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726423AbfHEHXq (ORCPT ); Mon, 5 Aug 2019 03:23:46 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:37391 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726394AbfHEHXq (ORCPT ); Mon, 5 Aug 2019 03:23:46 -0400 X-Originating-IP: 82.246.155.60 Received: from localhost (hy283-1-82-246-155-60.fbx.proxad.net [82.246.155.60]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 2239CC0004; Mon, 5 Aug 2019 07:23:40 +0000 (UTC) Date: Mon, 5 Aug 2019 09:23:38 +0200 From: Alexandre Belloni To: Hsin-Hsiung Wang Cc: Lee Jones , Rob Herring , Matthias Brugger , Mark Brown , Mark Rutland , Liam Girdwood , Eddie Huang , Sean Wang , Alessandro Zummo , Thomas Gleixner , Richard Fontana , Kate Stewart , Allison Randal , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, srv_heupstream@mediatek.com, Ran Bi Subject: Re: [PATCH v4 10/10] rtc: Add support for the MediaTek MT6358 RTC Message-ID: <20190805072338.GB3600@piout.net> References: <1564982518-32163-1-git-send-email-hsin-hsiung.wang@mediatek.com> <1564982518-32163-11-git-send-email-hsin-hsiung.wang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1564982518-32163-11-git-send-email-hsin-hsiung.wang@mediatek.com> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org Hi, The subject should be: "rtc: mt6397: Add support for the MediaTek MT6358 RTC" On 05/08/2019 13:21:58+0800, Hsin-Hsiung Wang wrote: > From: Ran Bi > > This add support for the MediaTek MT6358 RTC. Driver using > compatible data to store different RTC_WRTGR address offset. > > Review-by: Yingjoe Chen > Signed-off-by: Ran Bi > --- > drivers/rtc/rtc-mt6397.c | 43 +++++++++++++++++++++++++++++++++++-------- > 1 file changed, 35 insertions(+), 8 deletions(-) > > diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c > index 828def7..e23c215 100644 > --- a/drivers/rtc/rtc-mt6397.c > +++ b/drivers/rtc/rtc-mt6397.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -19,7 +20,8 @@ > #define RTC_BBPU 0x0000 > #define RTC_BBPU_CBUSY BIT(6) > > -#define RTC_WRTGR 0x003c > +#define RTC_WRTGR_MT6358 0x3a > +#define RTC_WRTGR_MT6397 0x3c > > #define RTC_IRQ_STA 0x0002 > #define RTC_IRQ_STA_AL BIT(0) > @@ -63,6 +65,10 @@ > #define RTC_NUM_YEARS 128 > #define RTC_MIN_YEAR_OFFSET (RTC_MIN_YEAR - RTC_BASE_YEAR) > > +struct mtk_rtc_compatible { I would name that struct mtk_rtc_data > + u32 wrtgr_addr; and this member should be wrtgr_offset or simply wrtgr. > +}; > + > struct mt6397_rtc { > struct device *dev; > struct rtc_device *rtc_dev; > @@ -70,7 +76,25 @@ struct mt6397_rtc { > struct regmap *regmap; > int irq; > u32 addr_base; > + const struct mtk_rtc_compatible *dev_comp; > +}; > + > +static const struct mtk_rtc_compatible mt6358_rtc_compat = { > + .wrtgr_addr = RTC_WRTGR_MT6358, > +}; > + > +static const struct mtk_rtc_compatible mt6397_rtc_compat = { > + .wrtgr_addr = RTC_WRTGR_MT6397, > +}; > + > +static const struct of_device_id mt6397_rtc_of_match[] = { > + { .compatible = "mediatek,mt6358-rtc", > + .data = (void *)&mt6358_rtc_compat, }, > + { .compatible = "mediatek,mt6397-rtc", > + .data = (void *)&mt6397_rtc_compat, }, > + {} > }; > +MODULE_DEVICE_TABLE(of, mt6397_rtc_of_match); > > static int mtk_rtc_write_trigger(struct mt6397_rtc *rtc) > { > @@ -78,7 +102,8 @@ static int mtk_rtc_write_trigger(struct mt6397_rtc *rtc) > int ret; > u32 data; > > - ret = regmap_write(rtc->regmap, rtc->addr_base + RTC_WRTGR, 1); > + ret = regmap_write(rtc->regmap, > + rtc->addr_base + rtc->dev_comp->wrtgr_addr, 1); > if (ret < 0) > return ret; > > @@ -324,6 +349,7 @@ static int mtk_rtc_probe(struct platform_device *pdev) > struct resource *res; > struct mt6397_chip *mt6397_chip = dev_get_drvdata(pdev->dev.parent); > struct mt6397_rtc *rtc; > + const struct of_device_id *of_id; > int ret; > > rtc = devm_kzalloc(&pdev->dev, sizeof(struct mt6397_rtc), GFP_KERNEL); > @@ -333,6 +359,13 @@ static int mtk_rtc_probe(struct platform_device *pdev) > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > rtc->addr_base = res->start; > > + of_id = of_match_device(mt6397_rtc_of_match, &pdev->dev); > + if (!of_id) { > + dev_err(&pdev->dev, "Failed to probe of_node\n"); > + return -EINVAL; This will never happen because probe would not be called if there is no match. You could also use of_device_get_match_data to avoid having to move the of_device_id table. > + } > + rtc->dev_comp = of_id->data; > + > rtc->irq = platform_get_irq(pdev, 0); > if (rtc->irq < 0) > return rtc->irq; > @@ -408,12 +441,6 @@ static int mt6397_rtc_resume(struct device *dev) > static SIMPLE_DEV_PM_OPS(mt6397_pm_ops, mt6397_rtc_suspend, > mt6397_rtc_resume); > > -static const struct of_device_id mt6397_rtc_of_match[] = { > - { .compatible = "mediatek,mt6397-rtc", }, > - { } > -}; > -MODULE_DEVICE_TABLE(of, mt6397_rtc_of_match); > - > static struct platform_driver mtk_rtc_driver = { > .driver = { > .name = "mt6397-rtc", > -- > 2.6.4 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com