From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Thomas Bogendoerfer <tbogendoerfer@suse.de>
Cc: Lee Jones <lee.jones@linaro.org>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@mips.com>,
James Hogan <jhogan@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org, netdev@vger.kernel.org,
linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v3 5/7] mfd: ioc3: Add driver for SGI IOC3 chip
Date: Fri, 9 Aug 2019 14:22:54 +0200 [thread overview]
Message-ID: <20190809122254.GN3600@piout.net> (raw)
In-Reply-To: <20190729204557.468db2153efefda96dd41ec0@suse.de>
On 29/07/2019 20:45:57+0200, Thomas Bogendoerfer wrote:
> On Thu, 25 Jul 2019 12:47:16 +0100
> Lee Jones <lee.jones@linaro.org> wrote:
>
> > On Thu, 13 Jun 2019, Thomas Bogendoerfer wrote:
> > > +/*
> > > + * On IP30 the RTC (a DS1687) is behind the IOC3 on the generic
> > > + * ByteBus regions. We have to write the RTC address of interest to
> > > + * IOC3_BYTEBUS_DEV1, then read the data from IOC3_BYTEBUS_DEV2.
> > > + * rtc->regs already points to IOC3_BYTEBUS_DEV1.
> > > + */
> > > +#define IP30_RTC_ADDR(rtc) (rtc->regs)
> > > +#define IP30_RTC_DATA(rtc) ((rtc->regs) + IOC3_BYTEBUS_DEV2 - IOC3_BYTEBUS_DEV1)
> > > +
> > > +static u8 ip30_rtc_read(struct ds1685_priv *rtc, int reg)
> > > +{
> > > + writeb((reg & 0x7f), IP30_RTC_ADDR(rtc));
> > > + return readb(IP30_RTC_DATA(rtc));
> > > +}
> > > +
> > > +static void ip30_rtc_write(struct ds1685_priv *rtc, int reg, u8 value)
> > > +{
> > > + writeb((reg & 0x7f), IP30_RTC_ADDR(rtc));
> > > + writeb(value, IP30_RTC_DATA(rtc));
> > > +}
> >
> > Why is this not in the RTC driver?
>
> because rtc1685 is used in different systems and accessing the chip
> differs between those systems.
>
> > > +static struct ds1685_rtc_platform_data ip30_rtc_platform_data = {
> > > + .bcd_mode = false,
> > > + .no_irq = false,
> > > + .uie_unsupported = true,
> > > + .alloc_io_resources = true,
> >
> > > + .plat_read = ip30_rtc_read,
> > > + .plat_write = ip30_rtc_write,
> >
> > Call-backs in a non-subsystem API is pretty ugly IMHO.
>
> I agree
>
> > Where are these called from?
>
> drivers/rtc/rtc-ds1685.c
>
> I could do the same as done for serial8250 and add an additional .c file
> in drivers/rtc which handles this for SGI-IP30. Alexandre would this work
> for you as well ?
>
As it is not particularly big, you could put that directly in
rtc-ds1685.c.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-08-09 12:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 17:06 [PATCH v3 0/7] Use MFD framework for SGI IOC3 drivers Thomas Bogendoerfer
2019-06-13 17:06 ` [PATCH v3 1/7] nvmem: core: add nvmem_device_find Thomas Bogendoerfer
2019-06-13 17:06 ` [PATCH v3 2/7] MIPS: PCI: refactor ioc3 special handling Thomas Bogendoerfer
2019-06-13 17:06 ` [PATCH v3 3/7] MIPS: PCI: use information from 1-wire PROM for IOC3 detection Thomas Bogendoerfer
2019-06-13 17:06 ` [PATCH v3 4/7] MIPS: SGI-IP27: remove ioc3 ethernet init Thomas Bogendoerfer
2019-06-13 17:06 ` [PATCH v3 6/7] MIPS: SGI-IP27: fix readb/writeb addressing Thomas Bogendoerfer
2019-06-13 17:06 ` [PATCH v3 7/7] Input: add IOC3 serio driver Thomas Bogendoerfer
2019-07-01 8:19 ` Dmitry Torokhov
[not found] ` <20190613170636.6647-6-tbogendoerfer@suse.de>
2019-07-25 11:47 ` [PATCH v3 5/7] mfd: ioc3: Add driver for SGI IOC3 chip Lee Jones
2019-07-29 18:45 ` Thomas Bogendoerfer
2019-08-09 12:22 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809122254.GN3600@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jhogan@kernel.org \
--cc=jslaby@suse.com \
--cc=lee.jones@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tbogendoerfer@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).