From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF47EC433FF for ; Mon, 12 Aug 2019 15:39:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C3A692085A for ; Mon, 12 Aug 2019 15:39:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726753AbfHLPjC (ORCPT ); Mon, 12 Aug 2019 11:39:02 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:45849 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726185AbfHLPjC (ORCPT ); Mon, 12 Aug 2019 11:39:02 -0400 X-Originating-IP: 92.137.69.152 Received: from localhost (alyon-656-1-672-152.w92-137.abo.wanadoo.fr [92.137.69.152]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 84BE91C0009; Mon, 12 Aug 2019 15:38:56 +0000 (UTC) Date: Mon, 12 Aug 2019 17:38:56 +0200 From: Alexandre Belloni To: Lee Jones Cc: Frank Wunderlich , Alessandro Zummo , Allison Randal , "David S. Miller" , devicetree@vger.kernel.org, Eddie Huang , Greg Kroah-Hartman , Jonathan Cameron , Kate Stewart , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org, Mark Rutland , Matthias Brugger , Mauro Carvalho Chehab , Nicolas Ferre , Richard Fontana , Rob Herring , Sean Wang , Sebastian Reichel , Thomas Gleixner , "Tianping . Fang" , Josef Friedl Subject: Re: [PATCH v5 03/10] rtc: mt6397: move some common definitions into rtc.h Message-ID: <20190812153856.GR3600@piout.net> References: <20190812121511.4169-1-frank-w@public-files.de> <20190812121511.4169-4-frank-w@public-files.de> <20190812151128.GV26727@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190812151128.GV26727@dell> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 12/08/2019 16:11:29+0100, Lee Jones wrote: > On Mon, 12 Aug 2019, Frank Wunderlich wrote: > > > From: Josef Friedl > > > > move code to separate header-file to reuse definitions later > > in poweroff-driver (drivers/power/reset/mt6323-poweroff.c) > > > > Suggested-by: Frank Wunderlich > > Signed-off-by: Josef Friedl > > Signed-off-by: Frank Wunderlich > > --- > > changes since v4: none > > changes since v3: none > > changes since v2: add missing commit-message > > --- > > drivers/rtc/rtc-mt6397.c | 55 +------------------------- > > include/linux/mfd/mt6397/rtc.h | 71 ++++++++++++++++++++++++++++++++++ > > include/linux/rtc/mt6397.h? > It's just a bunch of registers and bit definitions so it may as well stay close to include/linux/mfd/mt6397/registers.h -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com