From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: mazziesaccount@gmail.com, Alessandro Zummo <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
Randy Dunlap <rdunlap@infradead.org>,
Lee Jones <lee.jones@linaro.org>, Arnd Bergmann <arnd@arndb.de>,
"yuehaibing@huawei.com" <yuehaibing@huawei.com>
Subject: Re: [PATCH] rtc: bd70528: fix driver dependencies
Date: Mon, 12 Aug 2019 23:02:27 +0200 [thread overview]
Message-ID: <20190812210227.GU3600@piout.net> (raw)
In-Reply-To: <84462e01e43d39024948a3bdd24087ff87dc2255.1565591387.git.matti.vaittinen@fi.rohmeurope.com>
On 12/08/2019 09:36:11+0300, Matti Vaittinen wrote:
> With CONFIG_BD70528_WATCHDOG=m, a built-in rtc driver cannot call
> into the low-level functions that are part of the watchdog module:
>
> drivers/rtc/rtc-bd70528.o: In function `bd70528_set_time':
> rtc-bd70528.c:(.text+0x22c): undefined reference to `bd70528_wdt_lock'
> rtc-bd70528.c:(.text+0x2a8): undefined reference to `bd70528_wdt_unlock'
> drivers/rtc/rtc-bd70528.o: In function `bd70528_set_rtc_based_timers':
> rtc-bd70528.c:(.text+0x50c): undefined reference to `bd70528_wdt_set'
>
> Add a Kconfig dependency which forces RTC to be a module if watchdog is a
> module. If watchdog is not compiled at all the stub functions for watchdog
> control are used. compiling the RTC without watchdog is fine.
>
> Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528 RTC")
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> ---
> Issue was found by kbuildbot from linux-next. Issue was addressed by
> Arnd and Randy - but those solutions disallowed compiling the RTC
> without watchdog. This patch is a result of discussion with Arnd and it
> was created on top of Linus' tree (tag v5.3-rc4).
> drivers/rtc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-08-12 21:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 6:36 [PATCH] rtc: bd70528: fix driver dependencies Matti Vaittinen
2019-08-12 21:02 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190812210227.GU3600@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=arnd@arndb.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=rdunlap@infradead.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).