From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Fuqian Huang <huangfq.daxian@gmail.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: mxc: use spin_lock_irqsave instead of spin_lock_irq in IRQ context
Date: Mon, 12 Aug 2019 23:04:42 +0200 [thread overview]
Message-ID: <20190812210442.GV3600@piout.net> (raw)
In-Reply-To: <20190807082310.10135-1-huangfq.daxian@gmail.com>
On 07/08/2019 16:23:10+0800, Fuqian Huang wrote:
> As spin_unlock_irq will enable interrupts.
> mxc_rtc_irq_enable is called from interrupt handler mxc_rtc_interrupt.
> Interrupts are enabled in interrupt handler.
> Use spin_lock_irqsave/spin_unlock_irqrestore instead of spin_(un)lock_irq
> in IRQ context to avoid this.
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> ---
> drivers/rtc/rtc-mxc.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-08-12 21:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 8:23 [PATCH] rtc: mxc: use spin_lock_irqsave instead of spin_lock_irq in IRQ context Fuqian Huang
2019-08-12 21:04 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190812210442.GV3600@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=huangfq.daxian@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).