From: Rob Herring <robh@kernel.org>
To: Biwen Li <biwen.li@nxp.com>
Cc: a.zummo@towertech.it, alexandre.belloni@bootlin.com,
leoyang.li@nxp.com, linux-rtc@vger.kernel.org,
linux-kernel@vger.kernel.org, xiaobo.xie@nxp.com,
jiafei.pan@nxp.com, ran.wang_1@nxp.com, mark.rutland@arm.com,
devicetree@vger.kernel.org
Subject: Re: [v6,2/2] dt-bindings: rtc: add bindings for FlexTimer Module
Date: Mon, 12 Aug 2019 17:16:07 -0600 [thread overview]
Message-ID: <20190812231607.GA21242@bogus> (raw)
In-Reply-To: <20190719035400.9800-2-biwen.li@nxp.com>
On Fri, Jul 19, 2019 at 11:54:00AM +0800, Biwen Li wrote:
> The patch adds bindings for FlexTimer Module
>
> Signed-off-by: Biwen Li <biwen.li@nxp.com>
> ---
> Change in v6:
> - correct subject
> - delete note
> - remove reg property about IP Powerdown exception register
>
> Change in v5:
> - None
>
> Change in v4:
> - add note about dts and kernel options
> - add aliases in example
>
> Change in v3:
> - remove reg-names property
> - correct cells number
>
> Change in v2:
> - replace ls1043a with ls1088a as example
> - add rcpm node and fsl,rcpm-wakeup property
>
> .../bindings/rtc/rtc-fsl-ftm-alarm.txt | 41 +++++++++++++++++++
> 1 file changed, 41 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt
>
> diff --git a/Documentation/devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt b/Documentation/devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt
> new file mode 100644
> index 000000000000..9291b022ffc7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/rtc-fsl-ftm-alarm.txt
> @@ -0,0 +1,41 @@
> +Freescale FlexTimer Module (FTM) Alarm
> +
> +Required properties:
> +- compatible : Should be "fsl,<chip>-ftm-alarm", the
> + supported chips include
> + "fsl,ls1012a-ftm-alarm"
> + "fsl,ls1021a-ftm-alarm"
> + "fsl,ls1028a-ftm-alarm"
> + "fsl,ls1043a-ftm-alarm"
> + "fsl,ls1046a-ftm-alarm"
> + "fsl,ls1088a-ftm-alarm"
> + "fsl,ls208xa-ftm-alarm"
> +- reg : Specifies base physical address and size of the register sets for the
> + FlexTimer Module.
> +- interrupts : Should be the FlexTimer Module interrupt.
> +- fsl,rcpm-wakeup property and rcpm node : Please refer
> + Documentation/devicetree/bindings/soc/fsl/rcpm.txt
> +
> +Optional properties:
> +- big-endian: If the host controller is big-endian mode, specify this property.
> + The default endian mode is little-endian.
> +
> +Example:
> +aliases {
> + ...
> + rtc1 = ftm_alarm0; // Use FlexTimer Module as /dev/rtc1
> + ...
> +};
As I said before, drop this. It's not going to work when this is
converted to schema and the example is compiled. Feel free to convert
this to schema and see...
> +
> +rcpm: rcpm@1e34040 {
> + compatible = "fsl,ls1088a-rcpm", "fsl,qoriq-rcpm-2.1+";
> + reg = <0x0 0x1e34040 0x0 0x18>;
> + #fsl,rcpm-wakeup-cells = <6>;
> +};
> +
> +ftm_alarm0: timer@2800000 {
If this is an RTC, then rtc@...
> + compatible = "fsl,ls1088a-ftm-alarm";
> + reg = <0x0 0x2800000 0x0 0x10000>;
> + fsl,rcpm-wakeup = <&rcpm 0x0 0x0 0x0 0x0 0x4000 0x0>;
> + interrupts = <0 44 4>;
> +};
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-08-12 23:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 3:53 [v6,1/2] rtc/fsl: add FTM alarm driver as the wakeup source Biwen Li
2019-07-19 3:54 ` [v6,2/2] dt-bindings: rtc: add bindings for FlexTimer Module Biwen Li
2019-08-12 23:16 ` Rob Herring [this message]
2019-08-13 2:59 ` [EXT] " Biwen Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190812231607.GA21242@bogus \
--to=robh@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=biwen.li@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=jiafei.pan@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ran.wang_1@nxp.com \
--cc=xiaobo.xie@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).