From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Stephen Boyd <swboyd@chromium.org>
Cc: linux-kernel@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v6 39/57] rtc: Remove dev_err() usage after platform_get_irq()
Date: Tue, 13 Aug 2019 10:53:31 +0200 [thread overview]
Message-ID: <20190813085331.GX3600@piout.net> (raw)
In-Reply-To: <20190730181557.90391-40-swboyd@chromium.org>
On 30/07/2019 11:15:39-0700, Stephen Boyd wrote:
> We don't need dev_err() messages when platform_get_irq() fails now that
> platform_get_irq() prints an error message itself when something goes
> wrong. Let's remove these prints with a simple semantic patch.
>
> // <smpl>
> @@
> expression ret;
> struct platform_device *E;
> @@
>
> ret =
> (
> platform_get_irq(E, ...)
> |
> platform_get_irq_byname(E, ...)
> );
>
> if ( \( ret < 0 \| ret <= 0 \) )
> {
> (
> -if (ret != -EPROBE_DEFER)
> -{ ...
> -dev_err(...);
> -... }
> |
> ...
> -dev_err(...);
> )
> ...
> }
> // </smpl>
>
> While we're here, remove braces on if statements that only have one
> statement (manually).
>
> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: linux-rtc@vger.kernel.org
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
>
> Please apply directly to subsystem trees
>
> drivers/rtc/rtc-88pm80x.c | 1 -
> drivers/rtc/rtc-88pm860x.c | 4 +---
> drivers/rtc/rtc-ac100.c | 4 +---
> drivers/rtc/rtc-armada38x.c | 5 +----
> drivers/rtc/rtc-asm9260.c | 4 +---
> drivers/rtc/rtc-at91rm9200.c | 4 +---
> drivers/rtc/rtc-at91sam9.c | 4 +---
> drivers/rtc/rtc-bd70528.c | 5 +----
> drivers/rtc/rtc-davinci.c | 4 +---
> drivers/rtc/rtc-jz4740.c | 4 +---
> drivers/rtc/rtc-max77686.c | 5 +----
> drivers/rtc/rtc-mt7622.c | 1 -
> drivers/rtc/rtc-pic32.c | 4 +---
> drivers/rtc/rtc-pm8xxx.c | 4 +---
> drivers/rtc/rtc-puv3.c | 8 ++------
> drivers/rtc/rtc-pxa.c | 8 ++------
> drivers/rtc/rtc-rk808.c | 6 +-----
> drivers/rtc/rtc-s3c.c | 8 ++------
> drivers/rtc/rtc-sc27xx.c | 4 +---
> drivers/rtc/rtc-spear.c | 4 +---
> drivers/rtc/rtc-stm32.c | 1 -
> drivers/rtc/rtc-sun6i.c | 4 +---
> drivers/rtc/rtc-sunxi.c | 4 +---
> drivers/rtc/rtc-tegra.c | 4 +---
> drivers/rtc/rtc-vt8500.c | 4 +---
> drivers/rtc/rtc-xgene.c | 4 +---
> drivers/rtc/rtc-zynqmp.c | 8 ++------
> 27 files changed, 28 insertions(+), 92 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-08-13 8:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190730181557.90391-1-swboyd@chromium.org>
2019-07-30 18:15 ` [PATCH v6 39/57] rtc: Remove dev_err() usage after platform_get_irq() Stephen Boyd
2019-08-08 8:05 ` Geert Uytterhoeven
2019-08-13 8:53 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813085331.GX3600@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).