linux-rtc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [v2] rtc: pcf85363/pcf85263: fix error that failed to run hwclock -w
@ 2019-08-16  2:46 Biwen Li
  2019-08-16  8:04 ` Alexandre Belloni
  0 siblings, 1 reply; 18+ messages in thread
From: Biwen Li @ 2019-08-16  2:46 UTC (permalink / raw)
  To: a.zummo, alexandre.belloni, leoyang.li; +Cc: linux-rtc, linux-kernel, Biwen Li

Issue:
    - # hwclock -w
      hwclock: RTC_SET_TIME: Invalid argument

Why:
    - Relative patch: https://lkml.org/lkml/2019/4/3/55 , this patch
      will always check for unwritable registers, it will compare reg
      with max_register in regmap_writeable.

    - In drivers/rtc/rtc-pcf85363.c, CTRL_STOP_EN is 0x2e, but DT_100THS
      is 0, max_regiter is 0x2f, then reg will be equal to 0x30,
      '0x30 < 0x2f' is false,so regmap_writeable will return false.

    - Root cause: the buf[] was written to a wrong place in the file
      drivers/rtc/rtc-pcf85363.c

How:
    - Split of writing regs to two parts, first part writes control
      registers about stop_enable and resets, second part writes
      RTC time and date registers.

Signed-off-by: Biwen Li <biwen.li@nxp.com>
---
Change in v2:
	- add Why and How into commit message.
	 
 drivers/rtc/rtc-pcf85363.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-pcf85363.c b/drivers/rtc/rtc-pcf85363.c
index a075e77617dc..3450d615974d 100644
--- a/drivers/rtc/rtc-pcf85363.c
+++ b/drivers/rtc/rtc-pcf85363.c
@@ -166,7 +166,12 @@ static int pcf85363_rtc_set_time(struct device *dev, struct rtc_time *tm)
 	buf[DT_YEARS] = bin2bcd(tm->tm_year % 100);
 
 	ret = regmap_bulk_write(pcf85363->regmap, CTRL_STOP_EN,
-				tmp, sizeof(tmp));
+				tmp, 2);
+	if (ret)
+		return ret;
+
+	ret = regmap_bulk_write(pcf85363->regmap, DT_100THS,
+				buf, sizeof(tmp) - 2);
 	if (ret)
 		return ret;
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2019-08-26 10:40 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-16  2:46 [v2] rtc: pcf85363/pcf85263: fix error that failed to run hwclock -w Biwen Li
2019-08-16  8:04 ` Alexandre Belloni
2019-08-16 15:50   ` Li Yang
2019-08-16 16:28     ` Alexandre Belloni
2019-08-16 19:40       ` Li Yang
2019-08-20 18:22         ` Mark Brown
2019-08-20 18:33           ` Li Yang
2019-08-21 11:21             ` Mark Brown
2019-08-21 11:24               ` Alexandre Belloni
2019-08-21 11:30                 ` Mark Brown
2019-08-21 11:38                   ` Alexandre Belloni
2019-08-21 11:47                     ` Mark Brown
2019-08-21  6:20         ` Nandor Han
2019-08-26  4:29           ` [EXT] " Biwen Li
2019-08-26  9:17             ` Nandor Han
2019-08-26  9:49               ` Biwen Li
2019-08-26 10:06                 ` Alexandre Belloni
2019-08-26 10:40                   ` Biwen Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).