From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6306C3A5A1 for ; Thu, 22 Aug 2019 12:46:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 96D3C2070B for ; Thu, 22 Aug 2019 12:46:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731126AbfHVMqe (ORCPT ); Thu, 22 Aug 2019 08:46:34 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:43107 "EHLO relay11.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729922AbfHVMqe (ORCPT ); Thu, 22 Aug 2019 08:46:34 -0400 Received: from localhost (aclermont-ferrand-651-1-259-53.w86-207.abo.wanadoo.fr [86.207.98.53]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 01503100003; Thu, 22 Aug 2019 12:46:28 +0000 (UTC) Date: Thu, 22 Aug 2019 14:46:28 +0200 From: Alexandre Belloni To: Ran Bi Cc: Rob Herring , Matthias Brugger , Alessandro Zummo , Mark Rutland , Mauro Carvalho Chehab , "David S . Miller" , Greg Kroah-Hartman , Jonathan Cameron , Linus Walleij , Nicolas Ferre , linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, YT Shen , Eddie Huang , Yingjoe Chen , Flora Fu , Sean Wang Subject: Re: [PATCH v2 2/4] rtc: Add support for the MediaTek MT2712 RTC Message-ID: <20190822124628.GS27031@piout.net> References: <20190801110122.26834-1-ran.bi@mediatek.com> <20190801110122.26834-3-ran.bi@mediatek.com> <20190820201744.GZ3545@piout.net> <1566477254.12318.41.camel@mhfsdcap03> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1566477254.12318.41.camel@mhfsdcap03> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 22/08/2019 20:34:14+0800, Ran Bi wrote: > > > + /* RTC need POWERKEY1/2 match, then goto normal work mode */ > > > + mt2712_writel(rtc, MT2712_POWERKEY1, MT2712_POWERKEY1_KEY); > > > + mt2712_writel(rtc, MT2712_POWERKEY2, MT2712_POWERKEY2_KEY); > > > > This should be written when setting the time after power was lost. > > > > I suppose we can move this into mt2712_rtc_read_time function's "if > (p1 != MT2712_POWERKEY1_KEY || p2 != MT2712_POWERKEY2_KEY)" condition > which will be added at next patch. We need additional flag to mark this > condition or another if condition in mt2712_rtc_set_time fucntion if we > put these code in mt2712_rtc_set_time function. > It is fine to test both in read_time and in set_time. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com