From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DBCDC3A5A1 for ; Thu, 22 Aug 2019 21:28:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD2622339F for ; Thu, 22 Aug 2019 21:28:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388515AbfHVV2l (ORCPT ); Thu, 22 Aug 2019 17:28:41 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:60703 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388346AbfHVV2l (ORCPT ); Thu, 22 Aug 2019 17:28:41 -0400 X-Originating-IP: 90.65.161.137 Received: from localhost (lfbn-1-1545-137.w90-65.abo.wanadoo.fr [90.65.161.137]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 5FFED1C0004; Thu, 22 Aug 2019 21:28:39 +0000 (UTC) Date: Thu, 22 Aug 2019 23:28:39 +0200 From: Alexandre Belloni To: Bruno Thomsen Cc: linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org, a.zummo@towertech.it, wim@linux-watchdog.org, linux@roeck-us.net, u.kleine-koenig@pengutronix.de, bth@kamstrup.com Subject: Re: [PATCH v3 4/5] rtc: pcf2127: add watchdog feature support Message-ID: <20190822212839.GJ27031@piout.net> References: <20190822131936.18772-1-bruno.thomsen@gmail.com> <20190822131936.18772-4-bruno.thomsen@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190822131936.18772-4-bruno.thomsen@gmail.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 22/08/2019 15:19:35+0200, Bruno Thomsen wrote: > Add partial support for the watchdog functionality of > both PCF2127 and PCF2129 chips. > > The programmable watchdog timer is currently using a fixed > clock source of 1Hz. This result in a selectable range of > 1-255 seconds, which covers most embedded Linux use-cases. > > Clock sources of 4096Hz, 64Hz and 1/60Hz is mostly useful > in MCU use-cases. > > Countdown timer not available when using watchdog feature. > > Signed-off-by: Bruno Thomsen > --- > v3: removed 2 x dev_info() and 1 x dev_err() traces. > lowered dev_info() to dbg_info() in pcf2127_wdt_set_timeout. > removed unneeded ret variable in pcf2127_wdt_set_timeout. > v2: use new watchdog api, e.g. devm_watchdog_register_device. > remove watchdog Kconfig option. > update existing Kconfig option with additional information. > > drivers/rtc/Kconfig | 7 ++- > drivers/rtc/rtc-pcf2127.c | 118 ++++++++++++++++++++++++++++++++++++++ > 2 files changed, 124 insertions(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com