From: Biwen Li <biwen.li@nxp.com>
To: a.zummo@towertech.it, alexandre.belloni@bootlin.com,
leoyang.li@nxp.com, broonie@kernel.org, nandor.han@vaisala.com
Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
Biwen Li <biwen.li@nxp.com>
Subject: [v3] rtc: pcf85363/pcf85263: fix error that failed to run hwclock -w
Date: Mon, 26 Aug 2019 13:12:56 +0800 [thread overview]
Message-ID: <20190826051256.42139-1-biwen.li@nxp.com> (raw)
Issue:
- hwclock -w
hwclock: RTC_SET_TIME: Invalid argument
Why:
- Relative patch: https://lkml.org/lkml/2019/4/3/55 , this patch
will always check for unwritable registers, it will compare reg
with max_register in regmap_writeable.
- In drivers/rtc/rtc-pcf85363.c, CTRL_STOP_EN is 0x2e, but DT_100THS
is 0, max_regiter is 0x2f, then reg will be equal to 0x30,
0x30 < 0x2f is false,so regmap_writeable will return false.
How:
- increase max_register to skip failed
when checking max_register.
Signed-off-by: Biwen Li <biwen.li@nxp.com>
---
Change in v3:
- replace old scheme with new scheme:
increase max_register.
Change in v2:
- add Why and How into commit message.
drivers/rtc/rtc-pcf85363.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-pcf85363.c b/drivers/rtc/rtc-pcf85363.c
index a075e77617dc..e9d4ef59febd 100644
--- a/drivers/rtc/rtc-pcf85363.c
+++ b/drivers/rtc/rtc-pcf85363.c
@@ -336,7 +336,8 @@ static const struct pcf85x63_config pcf_85263_config = {
.regmap = {
.reg_bits = 8,
.val_bits = 8,
- .max_register = 0x2f,
+ .max_register = 0x2f * 2, /* skip failed when
+ checking max_register */
},
.num_nvram = 1
};
--
2.17.1
reply other threads:[~2019-08-26 5:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826051256.42139-1-biwen.li@nxp.com \
--to=biwen.li@nxp.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=nandor.han@vaisala.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).