From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Dmitry Torokhov <dtor@google.com>
Cc: Nick Crews <ncrews@chromium.org>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
Pavel Machek <pavel@ucw.cz>,
enric.balletbo@collabora.com, Benson Leung <bleung@chromium.org>,
dlaurie@chromium.org, Daniel Kurtz <djkurtz@chromium.org>
Subject: Re: [PATCH v3] rtc: wilco-ec: Handle reading invalid times
Date: Wed, 2 Oct 2019 17:34:10 +0200 [thread overview]
Message-ID: <20191002153410.GO4106@piout.net> (raw)
In-Reply-To: <CAE_wzQ9AodXUEANpDEQM+VYMVuxWmLoF0_1k-m5HdAfx+=01-A@mail.gmail.com>
On 02/10/2019 08:20:34-0700, Dmitry Torokhov wrote:
> > I'm still not convinced it is useful to have an error in dmesg when the
> > time is invalid, as long as userspace knows it is invalid. What is the
> > course of action for the end user when that happens?
>
> Report it, or, in our case, we will see it in the feedback logs.
> However I do agree that it is not the best option, even if we report
> error to userspace I am not sure if it will handle it properly. What
> userspace is supposed to do when presented with -EIO or similar?
>
I would say probably retry a few times if it gets -EIO and simply abort
in case of -EINVAL. I'm not aware of any userspace tool behaving that
way though. They all simply abort.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-10-02 15:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 20:32 [PATCH v3] rtc: wilco-ec: Handle reading invalid times Nick Crews
2019-09-25 20:51 ` Dmitry Torokhov
2019-10-01 19:53 ` Alexandre Belloni
2019-10-01 20:42 ` Dmitry Torokhov
2019-10-02 10:32 ` Alexandre Belloni
2019-10-02 15:20 ` Dmitry Torokhov
2019-10-02 15:34 ` Alexandre Belloni [this message]
2019-10-03 20:37 ` Nick Crews
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191002153410.GO4106@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=bleung@chromium.org \
--cc=djkurtz@chromium.org \
--cc=dlaurie@chromium.org \
--cc=dtor@google.com \
--cc=enric.balletbo@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=ncrews@chromium.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).