linux-rtc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
	linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: Add support for century bits to m41t62 (rv4162) RTC devices
Date: Thu, 3 Oct 2019 14:21:50 +0200	[thread overview]
Message-ID: <20191003142150.3d73a9d7@jawa> (raw)
In-Reply-To: <20191003114831.GR4106@piout.net>

[-- Attachment #1: Type: text/plain, Size: 2324 bytes --]

Hi Alexandre,

> Hello,
> 
> On 11/09/2019 17:48:03+0200, Lukasz Majewski wrote:
> > This change adds support for 'century bits' on 4162 family of RTC
> > devices (from ST or microcrystal), which allow storing time beyond
> > year 2099.
> > 
> > For rv4162 century bits - CB1[7]:CB0[6] are stored in reg6 - 0x6
> > (MONTH): CB1  CB0
> >  0    0      (year 2000 - 2099)
> >  0    1      (year 2100 - 2199)
> >  1    0      (year 2200 - 2299)
> >  1    1      (year 2300 - 2399)
> > 
> > The driver has been also adjusted to allow setting time up to year
> > 2399 if the M41T80_FEATURE_CB is set in its DTS/I2C data.
> > 
> > There shall be no functional changes for devices not supporting this
> > feature. However, other devices - like m41t80 - have different
> > approaches to handle century information.
> >   
> 
> This does not work because the RTC doesn't handle leap years on
> century properly. This means that if you do that, then there is no
> guarantee the date will be the correct after 2099. As far as the
> m41t62 and rv4162 are concerned, there is no way to make the century
> bits useful.

The code as is now doesn't allow to setup dates after year 2100.
In my application - I do some tests which depend on setting this time.

> 
> See the datasheet:
> 
> "During any year which is a multiple of 4, the RV-4162 RTC will
> automatically insert leap day, February 29.  Therefore, the
> application software must correct for this during the exception years
> (2100, 2200, etc.) as noted above."

I'm wondering what the phrase "application software" means here?

If it is the userland SW, then we shall at least be able to set 2099 in
this device and then count on software correction.

If the "application software" is the kernel driver - the date
correction shall be done there (maybe some lookup table?).

Personally, I do prefer the first option - this means that with this
patch we can set the time to e.g. 2234 year and then rely on userland
software (or libc) to do the correction.

> 




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2019-10-03 12:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-11 15:48 [PATCH] rtc: Add support for century bits to m41t62 (rv4162) RTC devices Lukasz Majewski
2019-09-30  7:56 ` Lukasz Majewski
2019-10-03 11:48 ` Alexandre Belloni
2019-10-03 12:21   ` Lukasz Majewski [this message]
2019-10-03 12:35     ` Alexandre Belloni
2019-10-03 13:14       ` Lukasz Majewski
2019-10-03 13:43         ` Alexandre Belloni
2019-10-03 14:10           ` Lukasz Majewski
2019-10-03 14:23             ` Alexandre Belloni
2019-10-03 14:49               ` Lukasz Majewski
2019-10-03 21:34                 ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191003142150.3d73a9d7@jawa \
    --to=lukma@denx.de \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).