* [PATCH 2/4] dt-bindings: rtc: s3c: Use defines instead of clock numbers
2019-10-02 16:07 [PATCH 1/4] dt-bindings: samsung: Indent examples with four spaces Krzysztof Kozlowski
@ 2019-10-02 16:07 ` Krzysztof Kozlowski
2019-10-07 13:17 ` Alexandre Belloni
2019-10-15 17:10 ` Rob Herring
2019-10-02 16:07 ` [PATCH 3/4] dt-bindings: rtc: s3c: Include generic dt-schema bindings Krzysztof Kozlowski
` (5 subsequent siblings)
6 siblings, 2 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2019-10-02 16:07 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Kukjin Kim, Krzysztof Kozlowski,
Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Sebastian Reichel, Alessandro Zummo,
Alexandre Belloni, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel, linux-iio, linux-pm, linux-rtc
Make the examples in S3C RTC bindings more readable and bring them
closer to real DTS by using defines for clocks.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Documentation/devicetree/bindings/rtc/s3c-rtc.yaml | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
index 95570d7e19eb..4d91cdc9b998 100644
--- a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
+++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
@@ -75,11 +75,14 @@ allOf:
examples:
- |
+ #include <dt-bindings/clock/exynos5420.h>
+ #include <dt-bindings/clock/samsung,s2mps11.h>
+
rtc@10070000 {
compatible = "samsung,s3c6410-rtc";
reg = <0x10070000 0x100>;
interrupts = <0 44 4>, <0 45 4>;
- clocks = <&clock 0>, // CLK_RTC
- <&s2mps11_osc 0>; // S2MPS11_CLK_AP
+ clocks = <&clock CLK_RTC>,
+ <&s2mps11_osc S2MPS11_CLK_AP>;
clock-names = "rtc", "rtc_src";
};
--
2.17.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 2/4] dt-bindings: rtc: s3c: Use defines instead of clock numbers
2019-10-02 16:07 ` [PATCH 2/4] dt-bindings: rtc: s3c: Use defines instead of clock numbers Krzysztof Kozlowski
@ 2019-10-07 13:17 ` Alexandre Belloni
2019-10-15 17:10 ` Rob Herring
1 sibling, 0 replies; 14+ messages in thread
From: Alexandre Belloni @ 2019-10-07 13:17 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Mark Rutland, Kukjin Kim, Jonathan Cameron,
Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Sebastian Reichel, Alessandro Zummo, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel, linux-iio,
linux-pm, linux-rtc
On 02/10/2019 18:07:42+0200, Krzysztof Kozlowski wrote:
> Make the examples in S3C RTC bindings more readable and bring them
> closer to real DTS by using defines for clocks.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> Documentation/devicetree/bindings/rtc/s3c-rtc.yaml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> index 95570d7e19eb..4d91cdc9b998 100644
> --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> @@ -75,11 +75,14 @@ allOf:
>
> examples:
> - |
> + #include <dt-bindings/clock/exynos5420.h>
> + #include <dt-bindings/clock/samsung,s2mps11.h>
> +
> rtc@10070000 {
> compatible = "samsung,s3c6410-rtc";
> reg = <0x10070000 0x100>;
> interrupts = <0 44 4>, <0 45 4>;
> - clocks = <&clock 0>, // CLK_RTC
> - <&s2mps11_osc 0>; // S2MPS11_CLK_AP
> + clocks = <&clock CLK_RTC>,
> + <&s2mps11_osc S2MPS11_CLK_AP>;
> clock-names = "rtc", "rtc_src";
> };
> --
> 2.17.1
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 2/4] dt-bindings: rtc: s3c: Use defines instead of clock numbers
2019-10-02 16:07 ` [PATCH 2/4] dt-bindings: rtc: s3c: Use defines instead of clock numbers Krzysztof Kozlowski
2019-10-07 13:17 ` Alexandre Belloni
@ 2019-10-15 17:10 ` Rob Herring
1 sibling, 0 replies; 14+ messages in thread
From: Rob Herring @ 2019-10-15 17:10 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Alessandro Zummo, Alexandre Belloni, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel, linux-iio,
linux-pm, linux-rtc
On Wed, 2 Oct 2019 18:07:42 +0200, Krzysztof Kozlowski wrote:
> Make the examples in S3C RTC bindings more readable and bring them
> closer to real DTS by using defines for clocks.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> Documentation/devicetree/bindings/rtc/s3c-rtc.yaml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
Applied, thanks.
Rob
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 3/4] dt-bindings: rtc: s3c: Include generic dt-schema bindings
2019-10-02 16:07 [PATCH 1/4] dt-bindings: samsung: Indent examples with four spaces Krzysztof Kozlowski
2019-10-02 16:07 ` [PATCH 2/4] dt-bindings: rtc: s3c: Use defines instead of clock numbers Krzysztof Kozlowski
@ 2019-10-02 16:07 ` Krzysztof Kozlowski
2019-10-07 13:17 ` Alexandre Belloni
2019-10-15 17:11 ` Rob Herring
2019-10-02 16:07 ` [PATCH 4/4] dt-bindings: iio: adc: exynos: Use defines instead of clock numbers Krzysztof Kozlowski
` (4 subsequent siblings)
6 siblings, 2 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2019-10-02 16:07 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Kukjin Kim, Krzysztof Kozlowski,
Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Sebastian Reichel, Alessandro Zummo,
Alexandre Belloni, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel, linux-iio, linux-pm, linux-rtc
Include the generic rtc.yaml bindings in Samsung S3C RTC bindings. This
brings the requirement of proper node names and adds parsing of
additional properties.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Documentation/devicetree/bindings/rtc/s3c-rtc.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
index 4d91cdc9b998..76bbf8b7555b 100644
--- a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
+++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
@@ -48,6 +48,7 @@ properties:
maxItems: 2
allOf:
+ - $ref: rtc.yaml#
- if:
properties:
compatible:
--
2.17.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 3/4] dt-bindings: rtc: s3c: Include generic dt-schema bindings
2019-10-02 16:07 ` [PATCH 3/4] dt-bindings: rtc: s3c: Include generic dt-schema bindings Krzysztof Kozlowski
@ 2019-10-07 13:17 ` Alexandre Belloni
2019-10-15 17:11 ` Rob Herring
1 sibling, 0 replies; 14+ messages in thread
From: Alexandre Belloni @ 2019-10-07 13:17 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Mark Rutland, Kukjin Kim, Jonathan Cameron,
Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Sebastian Reichel, Alessandro Zummo, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel, linux-iio,
linux-pm, linux-rtc
On 02/10/2019 18:07:43+0200, Krzysztof Kozlowski wrote:
> Include the generic rtc.yaml bindings in Samsung S3C RTC bindings. This
> brings the requirement of proper node names and adds parsing of
> additional properties.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> Documentation/devicetree/bindings/rtc/s3c-rtc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> index 4d91cdc9b998..76bbf8b7555b 100644
> --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> @@ -48,6 +48,7 @@ properties:
> maxItems: 2
>
> allOf:
> + - $ref: rtc.yaml#
> - if:
> properties:
> compatible:
> --
> 2.17.1
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/4] dt-bindings: rtc: s3c: Include generic dt-schema bindings
2019-10-02 16:07 ` [PATCH 3/4] dt-bindings: rtc: s3c: Include generic dt-schema bindings Krzysztof Kozlowski
2019-10-07 13:17 ` Alexandre Belloni
@ 2019-10-15 17:11 ` Rob Herring
1 sibling, 0 replies; 14+ messages in thread
From: Rob Herring @ 2019-10-15 17:11 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Alessandro Zummo, Alexandre Belloni, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel, linux-iio,
linux-pm, linux-rtc
On Wed, 2 Oct 2019 18:07:43 +0200, Krzysztof Kozlowski wrote:
> Include the generic rtc.yaml bindings in Samsung S3C RTC bindings. This
> brings the requirement of proper node names and adds parsing of
> additional properties.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> Documentation/devicetree/bindings/rtc/s3c-rtc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Applied, thanks.
Rob
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 4/4] dt-bindings: iio: adc: exynos: Use defines instead of clock numbers
2019-10-02 16:07 [PATCH 1/4] dt-bindings: samsung: Indent examples with four spaces Krzysztof Kozlowski
2019-10-02 16:07 ` [PATCH 2/4] dt-bindings: rtc: s3c: Use defines instead of clock numbers Krzysztof Kozlowski
2019-10-02 16:07 ` [PATCH 3/4] dt-bindings: rtc: s3c: Include generic dt-schema bindings Krzysztof Kozlowski
@ 2019-10-02 16:07 ` Krzysztof Kozlowski
2019-10-06 10:02 ` Jonathan Cameron
2019-10-15 17:11 ` Rob Herring
2019-10-06 10:01 ` [PATCH 1/4] dt-bindings: samsung: Indent examples with four spaces Jonathan Cameron
` (3 subsequent siblings)
6 siblings, 2 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2019-10-02 16:07 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Kukjin Kim, Krzysztof Kozlowski,
Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Sebastian Reichel, Alessandro Zummo,
Alexandre Belloni, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel, linux-iio, linux-pm, linux-rtc
Make the examples in Exynos ADC bindings more readable and bring them
closer to real DTS by using defines for clocks.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
.../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
index a0a9b909ac40..a3010e7ea051 100644
--- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
@@ -135,6 +135,8 @@ examples:
};
- |
+ #include <dt-bindings/clock/exynos3250.h>
+
adc@126c0000 {
compatible = "samsung,exynos3250-adc";
reg = <0x126C0000 0x100>;
@@ -142,8 +144,8 @@ examples:
#io-channel-cells = <1>;
io-channel-ranges;
- clocks = <&cmu 0>, // CLK_TSADC
- <&cmu 1>; // CLK_SCLK_TSADC
+ clocks = <&cmu CLK_TSADC>,
+ <&cmu CLK_SCLK_TSADC>;
clock-names = "adc", "sclk";
vdd-supply = <&buck5_reg>;
--
2.17.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 4/4] dt-bindings: iio: adc: exynos: Use defines instead of clock numbers
2019-10-02 16:07 ` [PATCH 4/4] dt-bindings: iio: adc: exynos: Use defines instead of clock numbers Krzysztof Kozlowski
@ 2019-10-06 10:02 ` Jonathan Cameron
2019-10-15 17:11 ` Rob Herring
1 sibling, 0 replies; 14+ messages in thread
From: Jonathan Cameron @ 2019-10-06 10:02 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Mark Rutland, Kukjin Kim, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald-Stadler, Sebastian Reichel,
Alessandro Zummo, Alexandre Belloni, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel, linux-iio,
linux-pm, linux-rtc
On Wed, 2 Oct 2019 18:07:44 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:
> Make the examples in Exynos ADC bindings more readable and bring them
> closer to real DTS by using defines for clocks.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> index a0a9b909ac40..a3010e7ea051 100644
> --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> @@ -135,6 +135,8 @@ examples:
> };
>
> - |
> + #include <dt-bindings/clock/exynos3250.h>
> +
> adc@126c0000 {
> compatible = "samsung,exynos3250-adc";
> reg = <0x126C0000 0x100>;
> @@ -142,8 +144,8 @@ examples:
> #io-channel-cells = <1>;
> io-channel-ranges;
>
> - clocks = <&cmu 0>, // CLK_TSADC
> - <&cmu 1>; // CLK_SCLK_TSADC
> + clocks = <&cmu CLK_TSADC>,
> + <&cmu CLK_SCLK_TSADC>;
> clock-names = "adc", "sclk";
>
> vdd-supply = <&buck5_reg>;
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 4/4] dt-bindings: iio: adc: exynos: Use defines instead of clock numbers
2019-10-02 16:07 ` [PATCH 4/4] dt-bindings: iio: adc: exynos: Use defines instead of clock numbers Krzysztof Kozlowski
2019-10-06 10:02 ` Jonathan Cameron
@ 2019-10-15 17:11 ` Rob Herring
1 sibling, 0 replies; 14+ messages in thread
From: Rob Herring @ 2019-10-15 17:11 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Alessandro Zummo, Alexandre Belloni, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel, linux-iio,
linux-pm, linux-rtc
On Wed, 2 Oct 2019 18:07:44 +0200, Krzysztof Kozlowski wrote:
> Make the examples in Exynos ADC bindings more readable and bring them
> closer to real DTS by using defines for clocks.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
Applied, thanks.
Rob
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/4] dt-bindings: samsung: Indent examples with four spaces
2019-10-02 16:07 [PATCH 1/4] dt-bindings: samsung: Indent examples with four spaces Krzysztof Kozlowski
` (2 preceding siblings ...)
2019-10-02 16:07 ` [PATCH 4/4] dt-bindings: iio: adc: exynos: Use defines instead of clock numbers Krzysztof Kozlowski
@ 2019-10-06 10:01 ` Jonathan Cameron
2019-10-07 13:17 ` Alexandre Belloni
` (2 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: Jonathan Cameron @ 2019-10-06 10:01 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Mark Rutland, Kukjin Kim, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald-Stadler, Sebastian Reichel,
Alessandro Zummo, Alexandre Belloni, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel, linux-iio,
linux-pm, linux-rtc
On Wed, 2 Oct 2019 18:07:41 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:
> Change the indentation of examples used in json-schema bindings from two
> to four spaces as this makes the code easier to read and seems to be
> preferred in other files.
>
I'm assuming Rob will pick these up given they span multiple subsystems.
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> # for iio
> ---
> .../bindings/arm/samsung/exynos-chipid.yaml | 4 +-
> .../bindings/iio/adc/samsung,exynos-adc.yaml | 64 +++++++++----------
> .../bindings/power/reset/syscon-poweroff.yaml | 8 +--
> .../bindings/power/reset/syscon-reboot.yaml | 8 +--
> .../devicetree/bindings/rtc/s3c-rtc.yaml | 12 ++--
> 5 files changed, 48 insertions(+), 48 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> index 9c573ad7dc7d..ce40adabb4e8 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> @@ -20,6 +20,6 @@ properties:
> examples:
> - |
> chipid@10000000 {
> - compatible = "samsung,exynos4210-chipid";
> - reg = <0x10000000 0x100>;
> + compatible = "samsung,exynos4210-chipid";
> + reg = <0x10000000 0x100>;
> };
> diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> index b4c6c26681d9..a0a9b909ac40 100644
> --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> @@ -112,40 +112,40 @@ allOf:
> examples:
> - |
> adc: adc@12d10000 {
> - compatible = "samsung,exynos-adc-v1";
> - reg = <0x12d10000 0x100>;
> - interrupts = <0 106 0>;
> - #io-channel-cells = <1>;
> - io-channel-ranges;
> -
> - clocks = <&clock 303>;
> - clock-names = "adc";
> -
> - vdd-supply = <&buck5_reg>;
> - samsung,syscon-phandle = <&pmu_system_controller>;
> -
> - /* NTC thermistor is a hwmon device */
> - ncp15wb473@0 {
> - compatible = "murata,ncp15wb473";
> - pullup-uv = <1800000>;
> - pullup-ohm = <47000>;
> - pulldown-ohm = <0>;
> - io-channels = <&adc 4>;
> - };
> + compatible = "samsung,exynos-adc-v1";
> + reg = <0x12d10000 0x100>;
> + interrupts = <0 106 0>;
> + #io-channel-cells = <1>;
> + io-channel-ranges;
> +
> + clocks = <&clock 303>;
> + clock-names = "adc";
> +
> + vdd-supply = <&buck5_reg>;
> + samsung,syscon-phandle = <&pmu_system_controller>;
> +
> + /* NTC thermistor is a hwmon device */
> + ncp15wb473@0 {
> + compatible = "murata,ncp15wb473";
> + pullup-uv = <1800000>;
> + pullup-ohm = <47000>;
> + pulldown-ohm = <0>;
> + io-channels = <&adc 4>;
> + };
> };
>
> - |
> adc@126c0000 {
> - compatible = "samsung,exynos3250-adc";
> - reg = <0x126C0000 0x100>;
> - interrupts = <0 137 0>;
> - #io-channel-cells = <1>;
> - io-channel-ranges;
> -
> - clocks = <&cmu 0>, // CLK_TSADC
> - <&cmu 1>; // CLK_SCLK_TSADC
> - clock-names = "adc", "sclk";
> -
> - vdd-supply = <&buck5_reg>;
> - samsung,syscon-phandle = <&pmu_system_controller>;
> + compatible = "samsung,exynos3250-adc";
> + reg = <0x126C0000 0x100>;
> + interrupts = <0 137 0>;
> + #io-channel-cells = <1>;
> + io-channel-ranges;
> +
> + clocks = <&cmu 0>, // CLK_TSADC
> + <&cmu 1>; // CLK_SCLK_TSADC
> + clock-names = "adc", "sclk";
> +
> + vdd-supply = <&buck5_reg>;
> + samsung,syscon-phandle = <&pmu_system_controller>;
> };
> diff --git a/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> index fb812937b534..520e07e6f21b 100644
> --- a/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> @@ -53,8 +53,8 @@ allOf:
> examples:
> - |
> poweroff {
> - compatible = "syscon-poweroff";
> - regmap = <®mapnode>;
> - offset = <0x0>;
> - mask = <0x7a>;
> + compatible = "syscon-poweroff";
> + regmap = <®mapnode>;
> + offset = <0x0>;
> + mask = <0x7a>;
> };
> diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> index a7920f5eef79..d38006b1f1f4 100644
> --- a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> @@ -53,8 +53,8 @@ allOf:
> examples:
> - |
> reboot {
> - compatible = "syscon-reboot";
> - regmap = <®mapnode>;
> - offset = <0x0>;
> - mask = <0x1>;
> + compatible = "syscon-reboot";
> + regmap = <®mapnode>;
> + offset = <0x0>;
> + mask = <0x1>;
> };
> diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> index 951a6a485709..95570d7e19eb 100644
> --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> @@ -76,10 +76,10 @@ allOf:
> examples:
> - |
> rtc@10070000 {
> - compatible = "samsung,s3c6410-rtc";
> - reg = <0x10070000 0x100>;
> - interrupts = <0 44 4>, <0 45 4>;
> - clocks = <&clock 0>, // CLK_RTC
> - <&s2mps11_osc 0>; // S2MPS11_CLK_AP
> - clock-names = "rtc", "rtc_src";
> + compatible = "samsung,s3c6410-rtc";
> + reg = <0x10070000 0x100>;
> + interrupts = <0 44 4>, <0 45 4>;
> + clocks = <&clock 0>, // CLK_RTC
> + <&s2mps11_osc 0>; // S2MPS11_CLK_AP
> + clock-names = "rtc", "rtc_src";
> };
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 1/4] dt-bindings: samsung: Indent examples with four spaces
2019-10-02 16:07 [PATCH 1/4] dt-bindings: samsung: Indent examples with four spaces Krzysztof Kozlowski
` (3 preceding siblings ...)
2019-10-06 10:01 ` [PATCH 1/4] dt-bindings: samsung: Indent examples with four spaces Jonathan Cameron
@ 2019-10-07 13:17 ` Alexandre Belloni
2019-10-10 16:48 ` Sebastian Reichel
2019-10-15 17:10 ` Rob Herring
6 siblings, 0 replies; 14+ messages in thread
From: Alexandre Belloni @ 2019-10-07 13:17 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Mark Rutland, Kukjin Kim, Jonathan Cameron,
Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Sebastian Reichel, Alessandro Zummo, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel, linux-iio,
linux-pm, linux-rtc
On 02/10/2019 18:07:41+0200, Krzysztof Kozlowski wrote:
> Change the indentation of examples used in json-schema bindings from two
> to four spaces as this makes the code easier to read and seems to be
> preferred in other files.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> .../bindings/arm/samsung/exynos-chipid.yaml | 4 +-
> .../bindings/iio/adc/samsung,exynos-adc.yaml | 64 +++++++++----------
> .../bindings/power/reset/syscon-poweroff.yaml | 8 +--
> .../bindings/power/reset/syscon-reboot.yaml | 8 +--
> .../devicetree/bindings/rtc/s3c-rtc.yaml | 12 ++--
> 5 files changed, 48 insertions(+), 48 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> index 9c573ad7dc7d..ce40adabb4e8 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> @@ -20,6 +20,6 @@ properties:
> examples:
> - |
> chipid@10000000 {
> - compatible = "samsung,exynos4210-chipid";
> - reg = <0x10000000 0x100>;
> + compatible = "samsung,exynos4210-chipid";
> + reg = <0x10000000 0x100>;
> };
> diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> index b4c6c26681d9..a0a9b909ac40 100644
> --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> @@ -112,40 +112,40 @@ allOf:
> examples:
> - |
> adc: adc@12d10000 {
> - compatible = "samsung,exynos-adc-v1";
> - reg = <0x12d10000 0x100>;
> - interrupts = <0 106 0>;
> - #io-channel-cells = <1>;
> - io-channel-ranges;
> -
> - clocks = <&clock 303>;
> - clock-names = "adc";
> -
> - vdd-supply = <&buck5_reg>;
> - samsung,syscon-phandle = <&pmu_system_controller>;
> -
> - /* NTC thermistor is a hwmon device */
> - ncp15wb473@0 {
> - compatible = "murata,ncp15wb473";
> - pullup-uv = <1800000>;
> - pullup-ohm = <47000>;
> - pulldown-ohm = <0>;
> - io-channels = <&adc 4>;
> - };
> + compatible = "samsung,exynos-adc-v1";
> + reg = <0x12d10000 0x100>;
> + interrupts = <0 106 0>;
> + #io-channel-cells = <1>;
> + io-channel-ranges;
> +
> + clocks = <&clock 303>;
> + clock-names = "adc";
> +
> + vdd-supply = <&buck5_reg>;
> + samsung,syscon-phandle = <&pmu_system_controller>;
> +
> + /* NTC thermistor is a hwmon device */
> + ncp15wb473@0 {
> + compatible = "murata,ncp15wb473";
> + pullup-uv = <1800000>;
> + pullup-ohm = <47000>;
> + pulldown-ohm = <0>;
> + io-channels = <&adc 4>;
> + };
> };
>
> - |
> adc@126c0000 {
> - compatible = "samsung,exynos3250-adc";
> - reg = <0x126C0000 0x100>;
> - interrupts = <0 137 0>;
> - #io-channel-cells = <1>;
> - io-channel-ranges;
> -
> - clocks = <&cmu 0>, // CLK_TSADC
> - <&cmu 1>; // CLK_SCLK_TSADC
> - clock-names = "adc", "sclk";
> -
> - vdd-supply = <&buck5_reg>;
> - samsung,syscon-phandle = <&pmu_system_controller>;
> + compatible = "samsung,exynos3250-adc";
> + reg = <0x126C0000 0x100>;
> + interrupts = <0 137 0>;
> + #io-channel-cells = <1>;
> + io-channel-ranges;
> +
> + clocks = <&cmu 0>, // CLK_TSADC
> + <&cmu 1>; // CLK_SCLK_TSADC
> + clock-names = "adc", "sclk";
> +
> + vdd-supply = <&buck5_reg>;
> + samsung,syscon-phandle = <&pmu_system_controller>;
> };
> diff --git a/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> index fb812937b534..520e07e6f21b 100644
> --- a/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> @@ -53,8 +53,8 @@ allOf:
> examples:
> - |
> poweroff {
> - compatible = "syscon-poweroff";
> - regmap = <®mapnode>;
> - offset = <0x0>;
> - mask = <0x7a>;
> + compatible = "syscon-poweroff";
> + regmap = <®mapnode>;
> + offset = <0x0>;
> + mask = <0x7a>;
> };
> diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> index a7920f5eef79..d38006b1f1f4 100644
> --- a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> @@ -53,8 +53,8 @@ allOf:
> examples:
> - |
> reboot {
> - compatible = "syscon-reboot";
> - regmap = <®mapnode>;
> - offset = <0x0>;
> - mask = <0x1>;
> + compatible = "syscon-reboot";
> + regmap = <®mapnode>;
> + offset = <0x0>;
> + mask = <0x1>;
> };
> diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> index 951a6a485709..95570d7e19eb 100644
> --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> @@ -76,10 +76,10 @@ allOf:
> examples:
> - |
> rtc@10070000 {
> - compatible = "samsung,s3c6410-rtc";
> - reg = <0x10070000 0x100>;
> - interrupts = <0 44 4>, <0 45 4>;
> - clocks = <&clock 0>, // CLK_RTC
> - <&s2mps11_osc 0>; // S2MPS11_CLK_AP
> - clock-names = "rtc", "rtc_src";
> + compatible = "samsung,s3c6410-rtc";
> + reg = <0x10070000 0x100>;
> + interrupts = <0 44 4>, <0 45 4>;
> + clocks = <&clock 0>, // CLK_RTC
> + <&s2mps11_osc 0>; // S2MPS11_CLK_AP
> + clock-names = "rtc", "rtc_src";
> };
> --
> 2.17.1
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 1/4] dt-bindings: samsung: Indent examples with four spaces
2019-10-02 16:07 [PATCH 1/4] dt-bindings: samsung: Indent examples with four spaces Krzysztof Kozlowski
` (4 preceding siblings ...)
2019-10-07 13:17 ` Alexandre Belloni
@ 2019-10-10 16:48 ` Sebastian Reichel
2019-10-15 17:10 ` Rob Herring
6 siblings, 0 replies; 14+ messages in thread
From: Sebastian Reichel @ 2019-10-10 16:48 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Mark Rutland, Kukjin Kim, Jonathan Cameron,
Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Alessandro Zummo, Alexandre Belloni, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel, linux-iio,
linux-pm, linux-rtc
[-- Attachment #1: Type: text/plain, Size: 6335 bytes --]
Hi,
On Wed, Oct 02, 2019 at 06:07:41PM +0200, Krzysztof Kozlowski wrote:
> Change the indentation of examples used in json-schema bindings from two
> to four spaces as this makes the code easier to read and seems to be
> preferred in other files.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Sebastian Reichel <sre@kernel.org> # for power/reset
-- Sebastian
> ---
> .../bindings/arm/samsung/exynos-chipid.yaml | 4 +-
> .../bindings/iio/adc/samsung,exynos-adc.yaml | 64 +++++++++----------
> .../bindings/power/reset/syscon-poweroff.yaml | 8 +--
> .../bindings/power/reset/syscon-reboot.yaml | 8 +--
> .../devicetree/bindings/rtc/s3c-rtc.yaml | 12 ++--
> 5 files changed, 48 insertions(+), 48 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> index 9c573ad7dc7d..ce40adabb4e8 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> @@ -20,6 +20,6 @@ properties:
> examples:
> - |
> chipid@10000000 {
> - compatible = "samsung,exynos4210-chipid";
> - reg = <0x10000000 0x100>;
> + compatible = "samsung,exynos4210-chipid";
> + reg = <0x10000000 0x100>;
> };
> diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> index b4c6c26681d9..a0a9b909ac40 100644
> --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> @@ -112,40 +112,40 @@ allOf:
> examples:
> - |
> adc: adc@12d10000 {
> - compatible = "samsung,exynos-adc-v1";
> - reg = <0x12d10000 0x100>;
> - interrupts = <0 106 0>;
> - #io-channel-cells = <1>;
> - io-channel-ranges;
> -
> - clocks = <&clock 303>;
> - clock-names = "adc";
> -
> - vdd-supply = <&buck5_reg>;
> - samsung,syscon-phandle = <&pmu_system_controller>;
> -
> - /* NTC thermistor is a hwmon device */
> - ncp15wb473@0 {
> - compatible = "murata,ncp15wb473";
> - pullup-uv = <1800000>;
> - pullup-ohm = <47000>;
> - pulldown-ohm = <0>;
> - io-channels = <&adc 4>;
> - };
> + compatible = "samsung,exynos-adc-v1";
> + reg = <0x12d10000 0x100>;
> + interrupts = <0 106 0>;
> + #io-channel-cells = <1>;
> + io-channel-ranges;
> +
> + clocks = <&clock 303>;
> + clock-names = "adc";
> +
> + vdd-supply = <&buck5_reg>;
> + samsung,syscon-phandle = <&pmu_system_controller>;
> +
> + /* NTC thermistor is a hwmon device */
> + ncp15wb473@0 {
> + compatible = "murata,ncp15wb473";
> + pullup-uv = <1800000>;
> + pullup-ohm = <47000>;
> + pulldown-ohm = <0>;
> + io-channels = <&adc 4>;
> + };
> };
>
> - |
> adc@126c0000 {
> - compatible = "samsung,exynos3250-adc";
> - reg = <0x126C0000 0x100>;
> - interrupts = <0 137 0>;
> - #io-channel-cells = <1>;
> - io-channel-ranges;
> -
> - clocks = <&cmu 0>, // CLK_TSADC
> - <&cmu 1>; // CLK_SCLK_TSADC
> - clock-names = "adc", "sclk";
> -
> - vdd-supply = <&buck5_reg>;
> - samsung,syscon-phandle = <&pmu_system_controller>;
> + compatible = "samsung,exynos3250-adc";
> + reg = <0x126C0000 0x100>;
> + interrupts = <0 137 0>;
> + #io-channel-cells = <1>;
> + io-channel-ranges;
> +
> + clocks = <&cmu 0>, // CLK_TSADC
> + <&cmu 1>; // CLK_SCLK_TSADC
> + clock-names = "adc", "sclk";
> +
> + vdd-supply = <&buck5_reg>;
> + samsung,syscon-phandle = <&pmu_system_controller>;
> };
> diff --git a/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> index fb812937b534..520e07e6f21b 100644
> --- a/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> @@ -53,8 +53,8 @@ allOf:
> examples:
> - |
> poweroff {
> - compatible = "syscon-poweroff";
> - regmap = <®mapnode>;
> - offset = <0x0>;
> - mask = <0x7a>;
> + compatible = "syscon-poweroff";
> + regmap = <®mapnode>;
> + offset = <0x0>;
> + mask = <0x7a>;
> };
> diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> index a7920f5eef79..d38006b1f1f4 100644
> --- a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> @@ -53,8 +53,8 @@ allOf:
> examples:
> - |
> reboot {
> - compatible = "syscon-reboot";
> - regmap = <®mapnode>;
> - offset = <0x0>;
> - mask = <0x1>;
> + compatible = "syscon-reboot";
> + regmap = <®mapnode>;
> + offset = <0x0>;
> + mask = <0x1>;
> };
> diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> index 951a6a485709..95570d7e19eb 100644
> --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> @@ -76,10 +76,10 @@ allOf:
> examples:
> - |
> rtc@10070000 {
> - compatible = "samsung,s3c6410-rtc";
> - reg = <0x10070000 0x100>;
> - interrupts = <0 44 4>, <0 45 4>;
> - clocks = <&clock 0>, // CLK_RTC
> - <&s2mps11_osc 0>; // S2MPS11_CLK_AP
> - clock-names = "rtc", "rtc_src";
> + compatible = "samsung,s3c6410-rtc";
> + reg = <0x10070000 0x100>;
> + interrupts = <0 44 4>, <0 45 4>;
> + clocks = <&clock 0>, // CLK_RTC
> + <&s2mps11_osc 0>; // S2MPS11_CLK_AP
> + clock-names = "rtc", "rtc_src";
> };
> --
> 2.17.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 1/4] dt-bindings: samsung: Indent examples with four spaces
2019-10-02 16:07 [PATCH 1/4] dt-bindings: samsung: Indent examples with four spaces Krzysztof Kozlowski
` (5 preceding siblings ...)
2019-10-10 16:48 ` Sebastian Reichel
@ 2019-10-15 17:10 ` Rob Herring
6 siblings, 0 replies; 14+ messages in thread
From: Rob Herring @ 2019-10-15 17:10 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Alessandro Zummo, Alexandre Belloni, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel, linux-iio,
linux-pm, linux-rtc
On Wed, 2 Oct 2019 18:07:41 +0200, Krzysztof Kozlowski wrote:
> Change the indentation of examples used in json-schema bindings from two
> to four spaces as this makes the code easier to read and seems to be
> preferred in other files.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> .../bindings/arm/samsung/exynos-chipid.yaml | 4 +-
> .../bindings/iio/adc/samsung,exynos-adc.yaml | 64 +++++++++----------
> .../bindings/power/reset/syscon-poweroff.yaml | 8 +--
> .../bindings/power/reset/syscon-reboot.yaml | 8 +--
> .../devicetree/bindings/rtc/s3c-rtc.yaml | 12 ++--
> 5 files changed, 48 insertions(+), 48 deletions(-)
>
Applied, thanks.
Rob
^ permalink raw reply [flat|nested] 14+ messages in thread