From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6552EC4360C for ; Fri, 11 Oct 2019 03:00:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 38E4021D71 for ; Fri, 11 Oct 2019 03:00:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="KzBWLKoF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726720AbfJKDAT (ORCPT ); Thu, 10 Oct 2019 23:00:19 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:46559 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726692AbfJKDAT (ORCPT ); Thu, 10 Oct 2019 23:00:19 -0400 Received: by mail-pg1-f196.google.com with SMTP id b8so4887401pgm.13 for ; Thu, 10 Oct 2019 20:00:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=nP3GB4eev/Uw/7TzzPBf7q6vVOFurBjXFqfQUZ+MDGI=; b=KzBWLKoFEXWJXPLXk8rihO70idubrVY0AvebVOxegnFY86QJmJGnQAku+lqeexuYjB 9G74EjZ5ZvlXtWdwx6WwfpqvWL6VZhkBTLucMGD8v4+2hORNhyJnUiBwwpBCF8JxvYyl Y/VEUCQaO4qMcQjX25jnBmyNowejWuBTvCczZAtLpuYiP3fyFPOQUIuwfkc7KI12BXX2 EwM6/7cZLGE5aW9q4v+KkZG7M4Ko8VEfRigsYkPSfXxu8CCT86YN8Kz/jywZSNG+JnPs /EYL79jv7SvwRhbBYvBe5MtI4NC0fHqrZX5X0RP9DTqt0mKF84SdidfQjH90hJrCfHuU JAsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=nP3GB4eev/Uw/7TzzPBf7q6vVOFurBjXFqfQUZ+MDGI=; b=fHiOZ1nx7IUAAl2zhewp9glV3hJW2ESJYtfSk0Rd8A1tp+5Sitey++gbEOKenaM/YR Kqv/Gly5RS2Cj28VLQf35yJF1MbIqxMuZwJqlKYv+dtWoEolrcTA7xq3j5bH7bFMgxlB 1Pt2X4+4xpzU4M0LmfXRMxJu1rAEjzHuqjlX/wBhnYnpECF+4gRoGHnD2z4gvf1+h+cK alFC2Ow0hLsuV3Qjujo0xMhOsfJrCjrySWVVO7poNTfTunqpG00N18KeYxFWPD87wsaQ XaN9HJ8gZMtwPuvnyh9Sr+a0e/1Dr0yCRJek3cdspMJ/5x8px6u2Hj+UPo5ywM09BegS UW5w== X-Gm-Message-State: APjAAAUu6Oo2Z+pKicZx2/OX1cZe0d5fdGSvO4c/D6DcodqY8gHGsR8k 3sVXXTGe+5P+U0xP49Mtb0+Zpw== X-Google-Smtp-Source: APXvYqyC7PSkR8RT7VypdyqNldAyGXeW91322WLbhsrNNwrkgAMBn6eiIibb+JzCUjR+ko/vo+L6ow== X-Received: by 2002:a65:688a:: with SMTP id e10mr13223631pgt.122.1570762818461; Thu, 10 Oct 2019 20:00:18 -0700 (PDT) Received: from cakuba.netronome.com (c-73-202-202-92.hsd1.ca.comcast.net. [73.202.202.92]) by smtp.gmail.com with ESMTPSA id q6sm8505284pgn.44.2019.10.10.20.00.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2019 20:00:18 -0700 (PDT) Date: Thu, 10 Oct 2019 20:00:02 -0700 From: Jakub Kicinski To: Thomas Bogendoerfer Cc: Jonathan Corbet , Ralf Baechle , Paul Burton , James Hogan , Lee Jones , "David S. Miller" , Srinivas Kandagatla , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v9 3/5] mfd: ioc3: Add driver for SGI IOC3 chip Message-ID: <20191010200002.5fe5f34f@cakuba.netronome.com> In-Reply-To: <20191010145953.21327-4-tbogendoerfer@suse.de> References: <20191010145953.21327-1-tbogendoerfer@suse.de> <20191010145953.21327-4-tbogendoerfer@suse.de> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On Thu, 10 Oct 2019 16:59:49 +0200, Thomas Bogendoerfer wrote: > dev = alloc_etherdev(sizeof(struct ioc3_private)); > - if (!dev) { > - err = -ENOMEM; > - goto out_disable; > - } > - > - if (pci_using_dac) > - dev->features |= NETIF_F_HIGHDMA; Looks like the NETIF_F_HIGHDMA feature will not longer be set, is that okay? > - err = pci_request_regions(pdev, "ioc3"); > - if (err) > - goto out_free; > + if (!dev) > + return -ENOMEM; > > SET_NETDEV_DEV(dev, &pdev->dev); > > ip = netdev_priv(dev); > - ip->dev = dev; > - ip->dma_dev = &pdev->dev; > - > - dev->irq = pdev->irq; > + ip->dma_dev = pdev->dev.parent; > + ip->regs = devm_platform_ioremap_resource(pdev, 0); > + if (!ip->regs) { > + err = -ENOMEM; > + goto out_free; > + }