From: Rob Herring <robh@kernel.org>
To: "Andreas Färber" <afaerber@suse.de>
Cc: linux-realtek-soc@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/8] dt-bindings: rtc: realtek: Convert RTD119x to schema
Date: Fri, 25 Oct 2019 16:20:15 -0500 [thread overview]
Message-ID: <20191025212015.GA29978@bogus> (raw)
In-Reply-To: <20191020040817.16882-3-afaerber@suse.de>
On Sun, Oct 20, 2019 at 06:08:11AM +0200, Andreas Färber wrote:
> Convert the RTD119x binding to a YAML schema.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> v2: New
>
> .../devicetree/bindings/rtc/realtek,rtd119x.txt | 16 ---------
> .../devicetree/bindings/rtc/realtek,rtd119x.yaml | 38 ++++++++++++++++++++++
> 2 files changed, 38 insertions(+), 16 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/rtc/realtek,rtd119x.txt
> create mode 100644 Documentation/devicetree/bindings/rtc/realtek,rtd119x.yaml
> diff --git a/Documentation/devicetree/bindings/rtc/realtek,rtd119x.yaml b/Documentation/devicetree/bindings/rtc/realtek,rtd119x.yaml
> new file mode 100644
> index 000000000000..71b7396bd469
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/realtek,rtd119x.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: GPL-2.0-or-later OR BSD-2-Clause
Missing ()
Though I'm not sure it matters other than consistency.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/realtek,rtd119x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Realtek RTD129x Real-Time Clock
> +
> +allOf:
> + - $ref: "rtc.yaml#"
> +
> +maintainers:
> + - Andreas Färber <afaerber@suse.de>
> +
> +properties:
> + compatible:
> + const: realtek,rtd1295-rtc
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> + description: Specifies the clock gate
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> +
> +examples:
> + - |
> + rtc@9801b600 {
> + compatible = "realtek,rtd1295-clk";
> + reg = <0x9801b600 0x100>;
> + clocks = <&clkc RTD1295_CLK_EN_MISC_RTC>;
You need the include file here or the example won't build (run 'make
dt_binding_check').
> + };
> +...
> --
> 2.16.4
>
next prev parent reply other threads:[~2019-10-25 21:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191020040817.16882-1-afaerber@suse.de>
2019-10-20 4:08 ` [PATCH v2 2/8] dt-bindings: rtc: realtek: Convert RTD119x to schema Andreas Färber
2019-10-25 21:20 ` Rob Herring [this message]
2019-10-28 10:46 ` Andreas Färber
2019-10-28 11:29 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025212015.GA29978@bogus \
--to=robh@kernel.org \
--cc=a.zummo@towertech.it \
--cc=afaerber@suse.de \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-realtek-soc@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).