From: Andreas Kemnade <andreas@kemnade.info>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: lee.jones@linaro.org, a.zummo@towertech.it,
linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
phh@phh.me, b.galvani@gmail.com, stefan@agner.ch,
letux-kernel@openphoenux.org
Subject: Re: [PATCH 5/5] rtc: rtc-rc5t583: add ricoh rc5t619 RTC driver
Date: Tue, 29 Oct 2019 07:46:03 +0100
Message-ID: <20191029074603.499a3940@kemnade.info> (raw)
In-Reply-To: <20191023231717.GU3125@piout.net>
[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]
On Thu, 24 Oct 2019 01:17:17 +0200
Alexandre Belloni <alexandre.belloni@bootlin.com> wrote:
[...]
> > > Is the RTC 1900-2099 or 2000-2199? Please include the ouput of rtc-range
> > > in the commit log:
> > >
> > > https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/rtc-tools.git/tree/rtc-range.c
> > >
> > # ./rtc-range
> >
> > Testing 2000-02-28 23:59:59.
> > OK
> >
> > Testing 2038-01-19 03:14:07.
> > OK
> >
> > Testing 2069-12-31 23:59:59.
> > OK
> >
> > Testing 2099-12-31 23:59:59.
> > KO RTC_RD_TIME returned 22 (line 138)
> >
> > Testing 2100-02-28 23:59:59.
> > KO RTC_RD_TIME returned 22 (line 138)
> >
> > Testing 2106-02-07 06:28:15.
> > OK
> >
> > Testing 2262-04-11 23:47:16.
> > KO Read back 2102-04-11 23:47:16.
> >
> > I think it is 1900 to 2099.
> >
>
> It is, I'm very curious to know why it doesn't roll over properly from
> 2099-12-31 23:59:59 to 1900-01-01 00:00:00.
>
It rolls over correcly, but rtc_valid_tm() bails out if
year < 70.
I am preparing a v2 of this series.
Regards,
Andreas
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply index
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 5:40 [PATCH 0/5] Add rtc support for rn5t618 mfd Andreas Kemnade
2019-10-21 5:41 ` [PATCH 1/5] mfd: rn5t618: prepare for irq handling Andreas Kemnade
2019-10-21 5:41 ` [PATCH 2/5] mfd: rn5t618: add irq support Andreas Kemnade
2019-10-21 9:07 ` Alexandre Belloni
2019-10-21 15:06 ` Andreas Kemnade
2019-10-21 5:41 ` [PATCH 3/5] mfd: rn5t618: add rtc related registers Andreas Kemnade
2019-10-21 5:41 ` [PATCH 4/5] mfd: rn5t618: add more subdevices Andreas Kemnade
2019-10-21 5:41 ` [PATCH 5/5] rtc: rtc-rc5t583: add ricoh rc5t619 RTC driver Andreas Kemnade
2019-10-21 10:15 ` Alexandre Belloni
2019-10-21 10:31 ` [Letux-kernel] " H. Nikolaus Schaller
2019-10-21 15:09 ` Alexandre Belloni
2019-10-21 21:13 ` Andreas Kemnade
2019-10-23 23:17 ` Alexandre Belloni
2019-10-24 20:25 ` Andreas Kemnade
2019-10-24 22:06 ` Alexandre Belloni
2019-10-29 6:46 ` Andreas Kemnade [this message]
2019-10-21 13:19 ` Stefan Agner
2019-10-21 13:50 ` Alexandre Belloni
2019-10-21 15:20 ` Andreas Kemnade
Reply instructions:
You may reply publically to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191029074603.499a3940@kemnade.info \
--to=andreas@kemnade.info \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=b.galvani@gmail.com \
--cc=lee.jones@linaro.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=phh@phh.me \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Linux-RTC Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/linux-rtc/0 linux-rtc/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 linux-rtc linux-rtc/ https://lore.kernel.org/linux-rtc \
linux-rtc@vger.kernel.org
public-inbox-index linux-rtc
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rtc
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git