* [PATCH 2/2] rtc: bd70528: Fix hour register mask
@ 2019-10-23 11:47 Matti Vaittinen
2019-11-05 16:53 ` Alexandre Belloni
0 siblings, 1 reply; 8+ messages in thread
From: Matti Vaittinen @ 2019-10-23 11:47 UTC (permalink / raw)
To: matti.vaittinen, mazziesaccount
Cc: Lee Jones, Alessandro Zummo, Alexandre Belloni, linux-rtc, linux-kernel
When RTC is used in 24H mode (and it is by this driver) the maximum
hour value is 24 in BCD. This occupies bits [5:0] - which means
correct mask for HOUR register is 0x3f not 0x1f. Fix the mask
Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528 RTC")
Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
---
include/linux/mfd/rohm-bd70528.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/mfd/rohm-bd70528.h b/include/linux/mfd/rohm-bd70528.h
index 1013e60c5b25..b0109ee6dae2 100644
--- a/include/linux/mfd/rohm-bd70528.h
+++ b/include/linux/mfd/rohm-bd70528.h
@@ -317,7 +317,7 @@ enum {
#define BD70528_MASK_RTC_MINUTE 0x7f
#define BD70528_MASK_RTC_HOUR_24H 0x80
#define BD70528_MASK_RTC_HOUR_PM 0x20
-#define BD70528_MASK_RTC_HOUR 0x1f
+#define BD70528_MASK_RTC_HOUR 0x3f
#define BD70528_MASK_RTC_DAY 0x3f
#define BD70528_MASK_RTC_WEEK 0x07
#define BD70528_MASK_RTC_MONTH 0x1f
--
2.21.0
--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND
~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =]
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] rtc: bd70528: Fix hour register mask
2019-10-23 11:47 [PATCH 2/2] rtc: bd70528: Fix hour register mask Matti Vaittinen
@ 2019-11-05 16:53 ` Alexandre Belloni
2019-11-05 16:57 ` Alexandre Belloni
2019-11-07 10:59 ` Lee Jones
0 siblings, 2 replies; 8+ messages in thread
From: Alexandre Belloni @ 2019-11-05 16:53 UTC (permalink / raw)
To: Matti Vaittinen
Cc: mazziesaccount, Lee Jones, Alessandro Zummo, linux-rtc, linux-kernel
On 23/10/2019 14:47:51+0300, Matti Vaittinen wrote:
> When RTC is used in 24H mode (and it is by this driver) the maximum
> hour value is 24 in BCD. This occupies bits [5:0] - which means
> correct mask for HOUR register is 0x3f not 0x1f. Fix the mask
>
> Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528 RTC")
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> ---
> include/linux/mfd/rohm-bd70528.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] rtc: bd70528: Fix hour register mask
2019-11-05 16:53 ` Alexandre Belloni
@ 2019-11-05 16:57 ` Alexandre Belloni
2019-11-05 18:13 ` Vaittinen, Matti
2019-11-07 10:59 ` Lee Jones
1 sibling, 1 reply; 8+ messages in thread
From: Alexandre Belloni @ 2019-11-05 16:57 UTC (permalink / raw)
To: Matti Vaittinen
Cc: mazziesaccount, Lee Jones, Alessandro Zummo, linux-rtc, linux-kernel
On 05/11/2019 17:53:18+0100, Alexandre Belloni wrote:
> On 23/10/2019 14:47:51+0300, Matti Vaittinen wrote:
> > When RTC is used in 24H mode (and it is by this driver) the maximum
> > hour value is 24 in BCD. This occupies bits [5:0] - which means
> > correct mask for HOUR register is 0x3f not 0x1f. Fix the mask
> >
> > Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528 RTC")
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > ---
> > include/linux/mfd/rohm-bd70528.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> Applied, thanks.
>
Actually, is there any point in doing that since "rtc: bd70528 add
BD71828 support" will conflict with it and correct the issue anyway?
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] rtc: bd70528: Fix hour register mask
2019-11-05 16:57 ` Alexandre Belloni
@ 2019-11-05 18:13 ` Vaittinen, Matti
0 siblings, 0 replies; 8+ messages in thread
From: Vaittinen, Matti @ 2019-11-05 18:13 UTC (permalink / raw)
To: alexandre.belloni
Cc: mazziesaccount, a.zummo, linux-rtc, linux-kernel, lee.jones
Hello Alexandre,
I'd expect the BD71828 support to still take a while. I don't expect it
to land in next kernel release. I'd prefer getting this fix in now (and
I hope it might also get merged to earlier releases by the 'fixes'
tag). So if it's not a problem for you then please apply this fix now -
I can rebase the BD71828 support when this fix is out :)
Br,
Matti Vaittinen
On Tue, 2019-11-05 at 17:57 +0100, Alexandre Belloni wrote:
> On 05/11/2019 17:53:18+0100, Alexandre Belloni wrote:
> > On 23/10/2019 14:47:51+0300, Matti Vaittinen wrote:
> > > When RTC is used in 24H mode (and it is by this driver) the
> > > maximum
> > > hour value is 24 in BCD. This occupies bits [5:0] - which means
> > > correct mask for HOUR register is 0x3f not 0x1f. Fix the mask
> > >
> > > Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM
> > > bd70528 RTC")
> > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com
> > > >
> > > ---
> > > include/linux/mfd/rohm-bd70528.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > Applied, thanks.
> >
>
> Actually, is there any point in doing that since "rtc: bd70528 add
> BD71828 support" will conflict with it and correct the issue anyway?
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] rtc: bd70528: Fix hour register mask
2019-11-05 16:53 ` Alexandre Belloni
2019-11-05 16:57 ` Alexandre Belloni
@ 2019-11-07 10:59 ` Lee Jones
2019-11-07 11:28 ` Alexandre Belloni
2019-11-07 11:46 ` Vaittinen, Matti
1 sibling, 2 replies; 8+ messages in thread
From: Lee Jones @ 2019-11-07 10:59 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Matti Vaittinen, mazziesaccount, Alessandro Zummo, linux-rtc,
linux-kernel
On Tue, 05 Nov 2019, Alexandre Belloni wrote:
> On 23/10/2019 14:47:51+0300, Matti Vaittinen wrote:
> > When RTC is used in 24H mode (and it is by this driver) the maximum
> > hour value is 24 in BCD. This occupies bits [5:0] - which means
> > correct mask for HOUR register is 0x3f not 0x1f. Fix the mask
> >
> > Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528 RTC")
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > ---
> > include/linux/mfd/rohm-bd70528.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> Applied, thanks.
You have been duped. This is clearly not an RTC patch.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] rtc: bd70528: Fix hour register mask
2019-11-07 10:59 ` Lee Jones
@ 2019-11-07 11:28 ` Alexandre Belloni
2019-11-07 17:38 ` Alexandre Belloni
2019-11-07 11:46 ` Vaittinen, Matti
1 sibling, 1 reply; 8+ messages in thread
From: Alexandre Belloni @ 2019-11-07 11:28 UTC (permalink / raw)
To: Lee Jones
Cc: Matti Vaittinen, mazziesaccount, Alessandro Zummo, linux-rtc,
linux-kernel
On 07/11/2019 10:59:49+0000, Lee Jones wrote:
> On Tue, 05 Nov 2019, Alexandre Belloni wrote:
>
> > On 23/10/2019 14:47:51+0300, Matti Vaittinen wrote:
> > > When RTC is used in 24H mode (and it is by this driver) the maximum
> > > hour value is 24 in BCD. This occupies bits [5:0] - which means
> > > correct mask for HOUR register is 0x3f not 0x1f. Fix the mask
> > >
> > > Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528 RTC")
> > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > > ---
> > > include/linux/mfd/rohm-bd70528.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > Applied, thanks.
>
> You have been duped. This is clearly not an RTC patch.
>
Well, it only affects the RTC driver. Do you want to take it?
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] rtc: bd70528: Fix hour register mask
2019-11-07 10:59 ` Lee Jones
2019-11-07 11:28 ` Alexandre Belloni
@ 2019-11-07 11:46 ` Vaittinen, Matti
1 sibling, 0 replies; 8+ messages in thread
From: Vaittinen, Matti @ 2019-11-07 11:46 UTC (permalink / raw)
To: lee.jones, alexandre.belloni
Cc: mazziesaccount, a.zummo, linux-rtc, linux-kernel
On Thu, 2019-11-07 at 10:59 +0000, Lee Jones wrote:
> On Tue, 05 Nov 2019, Alexandre Belloni wrote:
>
> > On 23/10/2019 14:47:51+0300, Matti Vaittinen wrote:
> > > When RTC is used in 24H mode (and it is by this driver) the
> > > maximum
> > > hour value is 24 in BCD. This occupies bits [5:0] - which means
> > > correct mask for HOUR register is 0x3f not 0x1f. Fix the mask
> > >
> > > Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM
> > > bd70528 RTC")
> > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com
> > > >
> > > ---
> > > include/linux/mfd/rohm-bd70528.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > Applied, thanks.
>
> You have been duped. This is clearly not an RTC patch.
Sorry. My bad. I used the rtc: prefix as this clearly is RTC fix -
although the header may be MFD territory. I should have known that
maintaining is done per file basis. I try to be more careful in the
future.
Br,
Matti Vaittinen
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] rtc: bd70528: Fix hour register mask
2019-11-07 11:28 ` Alexandre Belloni
@ 2019-11-07 17:38 ` Alexandre Belloni
0 siblings, 0 replies; 8+ messages in thread
From: Alexandre Belloni @ 2019-11-07 17:38 UTC (permalink / raw)
To: Lee Jones
Cc: Matti Vaittinen, mazziesaccount, Alessandro Zummo, linux-rtc,
linux-kernel
On 07/11/2019 12:33:53+0100, Alexandre Belloni wrote:
> On 07/11/2019 10:59:49+0000, Lee Jones wrote:
> > On Tue, 05 Nov 2019, Alexandre Belloni wrote:
> >
> > > On 23/10/2019 14:47:51+0300, Matti Vaittinen wrote:
> > > > When RTC is used in 24H mode (and it is by this driver) the maximum
> > > > hour value is 24 in BCD. This occupies bits [5:0] - which means
> > > > correct mask for HOUR register is 0x3f not 0x1f. Fix the mask
> > > >
> > > > Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528 RTC")
> > > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > > > ---
> > > > include/linux/mfd/rohm-bd70528.h | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > Applied, thanks.
> >
> > You have been duped. This is clearly not an RTC patch.
> >
>
> Well, it only affects the RTC driver. Do you want to take it?
>
I've removed it from rtc-next, up to you to take it.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-11-07 17:39 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-23 11:47 [PATCH 2/2] rtc: bd70528: Fix hour register mask Matti Vaittinen
2019-11-05 16:53 ` Alexandre Belloni
2019-11-05 16:57 ` Alexandre Belloni
2019-11-05 18:13 ` Vaittinen, Matti
2019-11-07 10:59 ` Lee Jones
2019-11-07 11:28 ` Alexandre Belloni
2019-11-07 17:38 ` Alexandre Belloni
2019-11-07 11:46 ` Vaittinen, Matti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).