From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FD01C5DF61 for ; Thu, 7 Nov 2019 11:33:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 607CC214D8 for ; Thu, 7 Nov 2019 11:33:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727437AbfKGLdz (ORCPT ); Thu, 7 Nov 2019 06:33:55 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:35761 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727278AbfKGLdz (ORCPT ); Thu, 7 Nov 2019 06:33:55 -0500 X-Originating-IP: 92.137.17.54 Received: from localhost (alyon-657-1-975-54.w92-137.abo.wanadoo.fr [92.137.17.54]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 2A6F51BF242; Thu, 7 Nov 2019 11:28:50 +0000 (UTC) Date: Thu, 7 Nov 2019 12:28:50 +0100 From: Alexandre Belloni To: Lee Jones Cc: Matti Vaittinen , mazziesaccount@gmail.com, Alessandro Zummo , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] rtc: bd70528: Fix hour register mask Message-ID: <20191107112850.GP8309@piout.net> References: <20191023114751.GA14100@localhost.localdomain> <20191105165317.GC8309@piout.net> <20191107105949.GA19195@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191107105949.GA19195@dell> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 07/11/2019 10:59:49+0000, Lee Jones wrote: > On Tue, 05 Nov 2019, Alexandre Belloni wrote: > > > On 23/10/2019 14:47:51+0300, Matti Vaittinen wrote: > > > When RTC is used in 24H mode (and it is by this driver) the maximum > > > hour value is 24 in BCD. This occupies bits [5:0] - which means > > > correct mask for HOUR register is 0x3f not 0x1f. Fix the mask > > > > > > Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528 RTC") > > > Signed-off-by: Matti Vaittinen > > > --- > > > include/linux/mfd/rohm-bd70528.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > Applied, thanks. > > You have been duped. This is clearly not an RTC patch. > Well, it only affects the RTC driver. Do you want to take it? -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com